fix(styleguide): fix faulty typing & invalid length check

republik · May 30, 2024 · d4fd192 · d4fd192
1 parent e641f08
commit d4fd192
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/packages/styleguide/src/components/Figure/Image.tsx b/packages/styleguide/src/components/Figure/Image.tsx
@@ -54,7 +54,7 @@ const GalleryButton = ({ gallerySize, onClick }: GalleryButtonProps) => {
 }
 
 type ImageProps = {
-  src: string
+  src?: string
   dark?: {
     src: string
     srcSet?: string

diff --git a/packages/styleguide/src/components/TeaserCarousel/Subject.tsx b/packages/styleguide/src/components/TeaserCarousel/Subject.tsx
@@ -1,14 +1,12 @@
 import { css } from 'glamor'
-import PropTypes from 'prop-types'
-import React from 'react'
+import React, { Children } from 'react'
 import { mUp } from '../TeaserFront/mediaQueries'
 import { sansSerifRegular16, sansSerifRegular18 } from '../Typography/styles'
 import { useColorContext } from '../Colors/useColorContext'
 
 const styles = css({
   ...sansSerifRegular16,
   lineHeight: '22px',
-
   [mUp]: {
     ...sansSerifRegular18,
     lineHeight: '24px',
@@ -23,7 +21,7 @@ const Subject = ({ children }: SubjectProps) => {
   const [colorScheme] = useColorContext()
   const customStyles = css(styles, {
     '&::after': {
-      content: children.length ? ' ' : undefined,
+      content: Children.count(children) > 0 ? ' ' : undefined,
     },
   })
   return (