Send mid-point data in a map #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jazg
reviewed
Aug 10, 2018
| prices map[currencyPair]float64 // Map of a currency pair to its latest price | ||
| cmcIDs map[string]int32 // Map of a token symbol to its CMC ID | ||
| pairCodes map[currencyPair]uint64 // Map of a currency pair to its pair-code | ||
| prices map[uint64]uint64 // Map of a currency pair to its latest price |
There was a problem hiding this comment.
Can you update the prices comment to make it clear it's now a map of the pair-code to its latest price?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update implementation to send mid-point data as a map of token-pairs with its respective prices.