Make it possible to run probot-settings as a GitHub Action #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This would be pretty handy to run as a github action instead of as a bot. An action is much easier to get integrated into an org than an app and can be easier to try it out. @elstudio would you resolve your conflicts? Maybe it's something that can be merged in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to run probot-settings as a GitHub Action.
If run from a GitHub action, the commit payload lacks the
modifiedandaddedproperties, see:https://github.blog/changelog/2019-10-16-changes-in-github-actions-push-event-payload/
This code now explicitly tests for these properties. If we have them (as if we were run as a typical Probot app), the code logic is unchanged.
But if these properties are missing — as in the case if we are run from an action — then act as if settings.yml has changed.
This makes it possible to run probot-settings from an action like this one: elstudio/actions-settings#11.