Skip to content

Update repository config on all default branch commits #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update repository config on all default branch commits #120

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,15 +6,15 @@ module.exports = (robot, _, Settings = require('./lib/settings')) => {
const payload = context.payload
const defaultBranch = payload.ref === 'refs/heads/' + payload.repository.default_branch

const config = await getConfig(context, 'settings.yml', {}, { arrayMerge: mergeArrayByName })
if (!defaultBranch) {
// Not the defualt branch, nothing to see here!
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Im not sure how to print with debug logs in probot :( but this should be a debug log

return;
}

const settingsModified = payload.commits.find(commit => {
return commit.added.includes(Settings.FILE_NAME) ||
commit.modified.includes(Settings.FILE_NAME)
const config = await getConfig(context, '/settings.yml', {}, {
arrayMerge: mergeArrayByName
})

if (defaultBranch && settingsModified) {
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved the if for applying settings or not to the top, as if its not the case, there is no point on running the deepmerge

return Settings.sync(context.github, context.repo(), config)
}
return Settings.sync(context.github, context.repo(), config)
})
}