Scope refactor #2111
Merged
Scope refactor #2111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves _tag_var to Scope, so that we have a single ContextVar rather than multiple.
philandstuff
force-pushed
the
scope-refactor
branch
from
5d9c549 to
ebd3903
Compare
philandstuff
force-pushed
the
scope-refactor
branch
from
aca3476 to
542adf0
Compare
erbridge
approved these changes
Jan 16, 2025
|
Recording a conversation I had with @erbridge: record_metric should indeed live on current_scope(). But this change is still worthy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small refactoring, which takes the _tag_var ContextVar and moves it to be a private attribute of Scope.
Once we've done this, I had hoped that record_metric wouldn't have to live on current_scope() any more (though it could still look up the tag from current_scope() if it wished), but my hopes were dashed because record_metric also needs to find self._events somehow.