Adds a node-compatible export#12
Open
gkjohnson wants to merge 6 commits into
Open
Conversation
gkjohnson
commented
Oct 16, 2024
Comment on lines
+11
to
+12
| constructor(...args:any[]) { | ||
| super(...args); |
Contributor
Author
There was a problem hiding this comment.
Typescript seems to not like this spread syntax for passing through the arguments to the parent constructor. I looked it up but there didn't seem to be a clear solution. Do we have to reproduce all the arguments and types for this constructor?
Contributor
Author
|
I'm also seeing this warning when running the node instance - looks like there's maybe a memory leak in xatlasjs? Or "comlink"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #9
node.tsfile.nodeentry to the webpack build so two entry points are built (one for browser, one for node)xatlas-three/nodeso the node variant can be used easily.Once node is working correctly there are a few things I'd like to adjust in future PRs if that's okay - let me know how this sounds:
BufferAttributeto the constructor.