docs: split Pay with Exchange & Self-custodial wallets into separate pages#754
docs: split Pay with Exchange & Self-custodial wallets into separate pages#754devin-ai-integration[bot] wants to merge 3 commits intomainfrom
Conversation
…pages Co-Authored-By: Jem Conlon <jem@walletconnect.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Claude finished @devin-ai-integration[bot]'s task in 2m 14s —— View job 🤖 Claude Code Review
Found 4 issue(s)Issue 1: Broken "Get Started" card links on self-custodial wallets pageID: pay-self-custodial-broken-links-a3f1 Context:
Recommendation: <Card icon="react" href="/appkit/react/payments/pay-with-self-custodial-wallets">
<Card icon="square-n" href="/appkit/next/payments/pay-with-self-custodial-wallets">
<Card icon="vuejs" href="/appkit/vue/payments/pay-with-self-custodial-wallets">
<Card icon="js" href="/appkit/javascript/payments/pay-with-self-custodial-wallets">Issue 2: Exchange-specific content on JavaScript self-custodial wallets pageID: js-self-custodial-exchange-content-b7c2 Context:
Recommendation:
Issue 3: React/Vue/Next.js stubs import exchange-focused snippetID: framework-stubs-exchange-snippet-c4d3 Context:
Recommendation: Either create a separate Issue 4: Typo in self-custodial wallets FAQID: pay-self-custodial-typo-e5f4 Context:
Recommendation: Change "connected" → "connect": Data classification: ✅ No issues found (all content is public-tier documentation) Tone of voice: ✅ Content is appropriately professional, informative, and aligned with Reown's voice guidelines. No violations found.
|
| ## Get Started | ||
|
|
||
| <CardGroup cols={2}> | ||
| <Card title="React" icon="react" href="/appkit/react/payments/pay-with-exchange"> |
There was a problem hiding this comment.
🤖 Auto Review Issue: Broken "Get Started" card links on self-custodial wallets page
Severity: HIGH
Category: breaking_change
Tool: Claude Auto Review
Context:
- Pattern: All four framework cards link to
/appkit/{framework}/payments/pay-with-exchangeinstead of the new self-custodial wallet pages - Risk: Users clicking "Get Started" from the self-custodial wallets page will land on exchange integration docs, causing confusion and misdirection
- Impact: Broken navigation for all four framework paths (React, Next.js, Vue, JavaScript)
- Trigger: Any user clicking the "Get Started" cards on the new page
Recommendation:
<Card icon="react" href="/appkit/react/payments/pay-with-self-custodial-wallets">
<Card icon="square-n" href="/appkit/next/payments/pay-with-self-custodial-wallets">
<Card icon="vuejs" href="/appkit/vue/payments/pay-with-self-custodial-wallets">
<Card icon="js" href="/appkit/javascript/payments/pay-with-self-custodial-wallets">|
|
||
| ## Supported Networks and Assets | ||
|
|
||
| For a complete list of supported networks and assets across different exchanges (Coinbase, Binance), please refer to the [Networks and Assets Supported](/appkit/payments/pay-with-exchange#networks-and-assets-supported) section in our Pay with Exchange documentation. |
There was a problem hiding this comment.
🤖 Auto Review Issue: Exchange-specific content on JavaScript self-custodial wallets page
Severity: HIGH
Category: code_quality
Tool: Claude Auto Review
Context:
- Pattern: Line 88 links to exchange-specific networks/assets ("across different exchanges (Coinbase, Binance)") and lists
getExchangesfunction (line 123-126) — both are exchange-only concepts - Risk: Developers building self-custodial wallet integrations will be misled into thinking they need exchange configuration or that
getExchangesis relevant to their use case - Impact: Inaccurate documentation; the JS self-custodial page is functionally identical to the exchange page (only the intro text differs)
- Trigger: Any developer reading the JavaScript integration guide for self-custodial wallets
Recommendation: - Line 88: Replace with a general "Supported Networks and Assets" statement not tied to exchange networks
- Lines 123-126: Remove
getExchangesfrom the functions list on the self-custodial page; it is exchange-only
| sidebarTitle: Pay with Self-Custodial Wallets | ||
| --- | ||
|
|
||
| import AppKitPay from "/snippets/appkit/shared/appkit-pay-react.mdx"; |
There was a problem hiding this comment.
🤖 Auto Review Issue: React/Vue/Next.js stubs import exchange-focused snippet
Severity: MEDIUM
Category: code_quality
Tool: Claude Auto Review
Context:
- Pattern: All three framework stubs import
appkit-pay-react.mdxwhich begins with "AppKit Pay with Exchange unlocks a powerful new flow: users can pay in crypto directly from their Centralized Exchange (CEXs) accounts", and contains exchange-only hooks (useAvailableExchanges,usePayUrlActions,useExchangeBuyStatus) and "Test the complete exchange flow" section - Risk: Self-custodial wallet pages will render exchange-specific content, contradicting the page title and misleading developers
- Impact: All three framework pages for self-custodial wallets will describe the exchange flow, not the wallet flow
- Trigger: Any developer following React/Vue/Next.js integration docs for self-custodial wallets
Recommendation: Either create a separate appkit-pay-wallet.mdx snippet, or add a parameter/flag to the shared snippet to conditionally render wallet vs. exchange content. This was flagged as item #2 in the PR description and needs a decision before merging.
| </Accordion> | ||
|
|
||
| <Accordion title="Can a user switch wallets?"> | ||
| Yes, a user can simply disconnect a wallet and connected another without losing the payment detail. |
There was a problem hiding this comment.
🤖 Auto Review Issue: Typo in self-custodial wallets FAQ
Severity: LOW
Category: code_quality
Tool: Claude Auto Review
Context:
- Pattern: "a user can simply disconnect a wallet and connected another"
- Risk: Grammatical error in user-facing docs
- Impact: Minor readability issue
Recommendation: Change "connected" → "connect": a user can simply disconnect a wallet and connect another without losing the payment detail.
Co-Authored-By: Jem Conlon <jem@walletconnect.com>
…om wallet pages, create wallet snippet Co-Authored-By: Jem Conlon <jem@walletconnect.com>
| import AppKitPayWallet from "/snippets/appkit/shared/appkit-pay-wallet-react.mdx"; | ||
|
|
||
| <AppKitPayWallet /> |
There was a problem hiding this comment.
Where is this coming from? <AppKitPayWallet /> doesnt' exist
There was a problem hiding this comment.
<AppKitPayWallet /> is the MDX component rendered from the import on line 6:
import AppKitPayWallet from "/snippets/appkit/shared/appkit-pay-wallet-react.mdx";This follows the same pattern used by the existing exchange pages — e.g., in appkit/react/payments/pay-with-exchange.mdx:
import AppKitPay from "/snippets/appkit/shared/appkit-pay-react.mdx";
<AppKitPay />The actual snippet content lives at snippets/appkit/shared/appkit-pay-wallet-react.mdx (created in this PR) — it's a wallet-focused version of appkit-pay-react.mdx with exchange-specific content removed.
Description
Splits the combined "Pay with Exchange & Self-Custodial Wallets" page into two dedicated pages:
Changes:
appkit/payments/pay-with-exchange.mdx— removed self-custodial wallet FAQs section; updated title and descriptions to be exchange-only; removed "early access" section (feature is now released)appkit/payments/pay-with-self-custodial-wallets.mdx— new page with intro, demo link, get started cards, and all wallet FAQs (User Experience, Compliance, Integration, Pricing, Strategic Benefits)appkit/payments/overview.mdx— updated to list both pages separately in the "How Reown Solves These Problems" section and added a separate card for self-custodial walletsdocs.json— addedpay-with-self-custodial-walletsto sidebar navigation for all 5 sections (overview, React, Next.js, Vue, JavaScript)payments/pay-with-self-custodial-wallets.mdxsnippets/appkit/shared/appkit-pay-wallet-react.mdx— new shared snippet for wallet framework stubs, with wallet-focused intro, no exchange-specific hooks/sections, andusePayhook documentationappkit/javascript/payments/pay-with-self-custodial-wallets.mdx— standalone JS wallet page with exchange-specific content removed (getExchangesfunction, exchange-specific network text)Updates since last revision
/appkit/{framework}/payments/pay-with-self-custodial-walletsappkit-pay-wallet-react.mdxsnippet so React/Next/Vue wallet stubs no longer render exchange-focused contentgetExchangesfrom the JS self-custodial page functions list (exchange-only)appkit-pay-wallet-react.mdx) documents ausePayhook in the Hooks section — please verify this is the correct/complete hook API for self-custodial wallet flows.@reown/appkit-paynpm package — confirm this is correct since both features share the SDK.Link to Devin run: https://app.devin.ai/sessions/55ed845aeae644068683a3d7966c07bb
Requested by: Jem Conlon (jem@walletconnect.com)
Tests
Direct link to the deployed preview files