Conversation
|
Claude finished @rtomas's task in 3s —— View job PR Review
🚨 PR Too Large All 41 files are mechanical version bumps, but this still exceeds the >15 file threshold. Since this is a test branch, it's likely intentional. Found 1 issue(s)Issue 1: Pre-release version pinned across all examplesID: package-prerelease-version-a7f3 Context:
Recommendation: Only merge to Additional observations:
|
| "dependencies": { | ||
| "@reown/appkit": "1.8.19", | ||
| "@reown/appkit-adapter-wagmi": "1.8.19", | ||
| "@reown/appkit": "1.8.20-switch-network.0", |
There was a problem hiding this comment.
🤖 Auto Review Issue: Pre-release version pinned across all examples
Severity: HIGH
Category: code_quality
Tool: Claude Auto Review
Context:
- Pattern: All
@reown/appkit*packages pinned to1.8.20-switch-network.0(a pre-release/canary version) instead of a stable release - Risk: Pre-release versions can be yanked from npm, have unstable APIs, or disappear; pinning them in example repos misleads users into using unstable packages
- Impact: Any developer cloning these examples and running
pnpm installwill install an unstable pre-release build that may not reflect the production SDK - Trigger: When this PR is merged to main and a user follows the examples
Recommendation: Only merge to main after 1.8.20 is published as a stable release. If this branch is purely for internal testing, it should not target main. Consider using a test/ or canary/ base branch instead.
No description provided.