Skip to content

Test switch network modal#178

Draft
rtomas wants to merge 1 commit intomainfrom
test/switch-network-version
Draft

Test switch network modal#178
rtomas wants to merge 1 commit intomainfrom
test/switch-network-version

Conversation

@rtomas
Copy link
Contributor

@rtomas rtomas commented Mar 13, 2026

No description provided.

@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
appkit-pay Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-javascript-bitcoin Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-javascript-ethers Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-javascript-solana Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-javascript-wagmi Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-next-bitcoin Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-next-ethers Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-next-multichain Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-next-solana Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-next-wagmi Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-bitcoin Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-core-up Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-ethers Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-ethers5 Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-multichain Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-solana Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-react-wagmi Building Building Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-vue-bitcoin Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-vue-ethers Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-vue-multichain Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-vue-solana Ready Ready Preview, Comment Mar 13, 2026 4:39pm
appkit-web-examples-vue-wagmi Ready Ready Preview, Comment Mar 13, 2026 4:39pm
react-core-universal-connector Ready Ready Preview, Comment Mar 13, 2026 4:39pm

Request Review

@claude
Copy link

claude bot commented Mar 13, 2026

Claude finished @rtomas's task in 3s —— View job


PR Review

  • Gather context
  • Analyze changed files
  • Run license compliance check
  • Run breaking changes check
  • Post final review

🚨 PR Too Large
Files: 41 Lines: ~186 changed
Severity: HIGH Category: maintainability

All 41 files are mechanical version bumps, but this still exceeds the >15 file threshold. Since this is a test branch, it's likely intentional.

Found 1 issue(s)

Issue 1: Pre-release version pinned across all examples

ID: package-prerelease-version-a7f3
File: react/react-wagmi/package.json:13 (and all 40 other package.json files)
Severity: HIGH
Category: code_quality

Context:

  • Pattern: All @reown/appkit* packages pinned to 1.8.20-switch-network.0 (a pre-release/canary version) instead of a stable release
  • Risk: Pre-release versions can be yanked from npm, have unstable APIs, or disappear; pinning them in example repos misleads users into using unstable packages
  • Impact: Any developer cloning these examples and running pnpm install will install an unstable pre-release build that may not reflect the production SDK
  • Trigger: When this PR is merged to main and a user follows the examples

Recommendation: Only merge to main after 1.8.20 is published as a stable release. If this branch is purely for internal testing, it should not target main. Consider using a test/ or canary/ base branch instead.

Additional observations:

  • bob network added only to react/react-wagmi/src/config/index.tsx but not other framework examples — intentional for isolated testing or needs propagation?
  • License compliance: ✅ No issues (only version bumps of existing @reown deps, no new packages added)
  • Breaking changes: ✅ No issues (additive-only changes)

"dependencies": {
"@reown/appkit": "1.8.19",
"@reown/appkit-adapter-wagmi": "1.8.19",
"@reown/appkit": "1.8.20-switch-network.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Auto Review Issue: Pre-release version pinned across all examples

Severity: HIGH
Category: code_quality
Tool: Claude Auto Review

Context:

  • Pattern: All @reown/appkit* packages pinned to 1.8.20-switch-network.0 (a pre-release/canary version) instead of a stable release
  • Risk: Pre-release versions can be yanked from npm, have unstable APIs, or disappear; pinning them in example repos misleads users into using unstable packages
  • Impact: Any developer cloning these examples and running pnpm install will install an unstable pre-release build that may not reflect the production SDK
  • Trigger: When this PR is merged to main and a user follows the examples

Recommendation: Only merge to main after 1.8.20 is published as a stable release. If this branch is purely for internal testing, it should not target main. Consider using a test/ or canary/ base branch instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant