Skip to content

Fixed HTTPSTAT_SAVE_BODY not working with HTTPSTAT_METRICS_ONLY #49

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixed HTTPSTAT_SAVE_BODY not working with HTTPSTAT_METRICS_ONLY #49

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 11 additions & 6 deletions httpstat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ def get(self, default=None):
ENV_SHOW_BODY = Env('{prefix}_SHOW_BODY')
ENV_SHOW_IP = Env('{prefix}_SHOW_IP')
ENV_SHOW_SPEED = Env('{prefix}_SHOW_SPEED')
ENV_SAVE_BODY = Env('{prefix}_SAVE_BODY')
ENV_SAVE_RESPONSE = Env('{prefix}_SAVE_RESPONSE')
Copy link

@gemini-code-assist gemini-code-assist bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming ENV_SAVE_BODY to ENV_SAVE_RESPONSE improves clarity. Ensure corresponding updates are made in the help text (lines 143-144) and README.md to reflect this change.

ENV_CURL_BIN = Env('{prefix}_CURL_BIN')
ENV_METRICS_ONLY = Env('{prefix}_METRICS_ONLY')
ENV_DEBUG = Env('{prefix}_DEBUG')
Expand Down Expand Up @@ -159,7 +159,7 @@ def main():
show_body = 'true' in ENV_SHOW_BODY.get('false').lower()
show_ip = 'true' in ENV_SHOW_IP.get('true').lower()
show_speed = 'true'in ENV_SHOW_SPEED.get('false').lower()
save_body = 'true' in ENV_SAVE_BODY.get('true').lower()
save_response = 'true' in ENV_SAVE_RESPONSE.get('true').lower()
Copy link

@gemini-code-assist gemini-code-assist bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming save_body to save_response improves clarity. Ensure corresponding updates are made in the test script httpstat_test.sh (lines 85-109).

curl_bin = ENV_CURL_BIN.get('curl')
metrics_only = 'true' in ENV_METRICS_ONLY.get('false').lower()
is_debug = 'true' in ENV_DEBUG.get('false').lower()
Expand All @@ -178,7 +178,7 @@ def main():
show_body=show_body,
show_ip=show_ip,
show_speed=show_speed,
save_body=save_body,
save_response=save_response,
Copy link

@gemini-code-assist gemini-code-assist bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Renaming save_body to save_response improves clarity. Ensure corresponding updates are made in the test script httpstat_test.sh (lines 85-109).

curl_bin=curl_bin,
is_debug=is_debug,
))
Expand Down Expand Up @@ -275,6 +275,11 @@ def main():
# print json if metrics_only is enabled
if metrics_only:
print(json.dumps(d, indent=2))
if not save_response:
lg.debug('rm header file %s', headerf.name)
os.remove(headerf.name)
lg.debug('rm body file %s', bodyf.name)
os.remove(bodyf.name)
Comment on lines +278 to +282
Copy link

@gemini-code-assist gemini-code-assist bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This block removes both header and body files when metrics_only is enabled and save_response is false, which fixes the original issue. Good job!

quit(None, 0)

# ip
Expand Down Expand Up @@ -314,17 +319,17 @@ def main():
print(body[:body_limit] + cyan('...'))
print()
s = '{} is truncated ({} out of {})'.format(green('Body'), body_limit, body_len)
if save_body:
if save_response:
s += ', stored in: {}'.format(bodyf.name)
print(s)
else:
print(body)
else:
if save_body:
if save_response:
print('{} stored in: {}'.format(green('Body'), bodyf.name))

# remove body file
if not save_body:
if not save_response:
lg.debug('rm body file %s', bodyf.name)
os.remove(bodyf.name)
Comment on lines +332 to 334
Copy link

@gemini-code-assist gemini-code-assist bot Jun 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This block removes the body file when save_response is false. This ensures that temporary files are cleaned up when they are no longer needed, preventing potential disk space issues.


Expand Down