Skip to content

bug-report - param containing double encoded characters should not be double decoded by useParams #13813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

qtoden
Copy link

@qtoden qtoden commented Jun 16, 2025

It seems parameters which are encoded using encodeURIComponent are automatically decoded when using useParams or matchPath.

So if I encode them twice, I expect them to be encoded once, after calling useParams. However, it seems like there is something special with forward slash (/). It is fully decoded after getting it with useParams, whereas matchPath works as expected.

Copy link

changeset-bot bot commented Jun 16, 2025

⚠️ No Changeset found

Latest commit: 9b855ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 16, 2025

Hi @qtoden,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 16, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

qtoden added 2 commits June 16, 2025 15:19
…d with encodeURIComponent should not be decoded by useParams/matchPath
@qtoden qtoden force-pushed the test-pre-encoded-forward-slash-in-param branch from 061b5d4 to 9b855ab Compare June 16, 2025 13:19
@qtoden
Copy link
Author

qtoden commented Jun 16, 2025

Seems very related to #11293

@qtoden qtoden changed the title bug-report - param containing forward slash encoded with encodeURIComponent should not be decoded by useParams/matchPath bug-report - param containing double encoded characters should not be double decoded by useParams Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant