Skip to content

feat(dev): update vite-node for Vite 7 support #13781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 2, 2025

Conversation

sapphi-red
Copy link
Contributor

This PR will fix a ecosystem-ci failure that will happen after merging vitejs/vite#19996.

vite-node 3.2 supports older Vite versions, so this change should not break anything.

Copy link

changeset-bot bot commented Jun 9, 2025

🦋 Changeset detected

Latest commit: 2da3bb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages
Name Type
@react-router/dev Patch
@react-router/fs-routes Patch
@react-router/remix-routes-option-adapter Patch
create-react-router Patch
react-router Patch
react-router-dom Patch
@react-router/architect Patch
@react-router/cloudflare Patch
@react-router/express Patch
@react-router/node Patch
@react-router/serve Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2025

Hi @sapphi-red,

Welcome, and thank you for contributing to React Router!

Before we consider your pull request, we ask that you sign our Contributor License Agreement (CLA). We require this only once.

You may review the CLA and sign it by adding your name to contributors.yml.

Once the CLA is signed, the CLA Signed label will be added to the pull request.

If you have already signed the CLA and received this response in error, or if you have any questions, please contact us at [email protected].

Thanks!

- The Remix team

@remix-cla-bot
Copy link
Contributor

remix-cla-bot bot commented Jun 9, 2025

Thank you for signing the Contributor License Agreement. Let's get this merged! 🥳

@MichaelDeBoey MichaelDeBoey changed the title feat(dev): update vite-node for Vite 7 feat(dev): update vite-node for Vite 7 support Jun 10, 2025
@brophdawg11
Copy link
Contributor

I'm going to defer to @markdalgleish here since he did the vite 7 work

@brophdawg11 brophdawg11 removed their request for review June 27, 2025 19:19
@markdalgleish markdalgleish changed the base branch from main to dev July 2, 2025 04:31
Copy link
Member

@markdalgleish markdalgleish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@brophdawg11 brophdawg11 merged commit f668100 into remix-run:dev Jul 2, 2025
8 checks passed
@sapphi-red sapphi-red deleted the feat/dev-vite-node-for-vite7 branch July 3, 2025 06:21
vezaynk pushed a commit to vezaynk/react-router that referenced this pull request Jul 7, 2025
Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0-pre.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Copy link
Contributor

🤖 Hello there,

We just published version 7.7.0 which includes this pull request. If you'd like to take it for a test run please try it out and let us know what you think!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants