Skip to content

feat(cloudflare): allow prefix on createWorkersKVSessionStorage #13778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sergiodxa wants to merge 4 commits into from
Closed

feat(cloudflare): allow prefix on createWorkersKVSessionStorage #13778

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cfa892c
Allow prefix on createWorkersKVSessionStorare
sergiodxa Jun 8, 2025
d7ddde1
Create sharp-yaks-bathe.md
sergiodxa Jun 8, 2025
a912f99
Update .changeset/sharp-yaks-bathe.md
MichaelDeBoey Jun 10, 2025
f20b033
Update .changeset/sharp-yaks-bathe.md
MichaelDeBoey Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sharp-yaks-bathe.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@react-router/cloudflare": minor
---

Allow prefix on createWorkersKVSessionStorare
Comment thread
MichaelDeBoey marked this conversation as resolved.
Outdated
16 changes: 11 additions & 5 deletions packages/react-router-cloudflare/sessions/workersKVStorage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ interface WorkersKVSessionStorageOptions {
* The KVNamespace used to store the sessions.
*/
kv: KVNamespace;

/**
* Optional prefix for the session keys in the KV store.
*/
prefix?: string;
}

/**
Expand All @@ -30,6 +35,7 @@ export function createWorkersKVSessionStorage<
>({
cookie,
kv,
prefix,
}: WorkersKVSessionStorageOptions): SessionStorage<Data, FlashData> {
return createSessionStorage({
cookie,
Expand All @@ -44,11 +50,11 @@ export function createWorkersKVSessionStorage<
.map((x) => x.toString(16).padStart(2, "0"))
.join("");

if (await kv.get(id, "json")) {
if (await kv.get(`${prefix}${id}`, "json")) {
continue;
}

await kv.put(id, JSON.stringify(data), {
await kv.put(`${prefix}${id}`, JSON.stringify(data), {
expiration: expires
? Math.round(expires.getTime() / 1000)
: undefined,
Expand All @@ -58,7 +64,7 @@ export function createWorkersKVSessionStorage<
}
},
async readData(id) {
let session = await kv.get(id);
let session = await kv.get(`${prefix}${id}`);

if (!session) {
return null;
Expand All @@ -67,12 +73,12 @@ export function createWorkersKVSessionStorage<
return JSON.parse(session);
},
async updateData(id, data, expires) {
await kv.put(id, JSON.stringify(data), {
await kv.put(`${prefix}${id}`, JSON.stringify(data), {
expiration: expires ? Math.round(expires.getTime() / 1000) : undefined,
});
},
async deleteData(id) {
await kv.delete(id);
await kv.delete(`${prefix}${id}`);
},
});
}