Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add adobe/remark-gridtables #1394

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Add adobe/remark-gridtables #1394

merged 3 commits into from
Jan 2, 2025

Conversation

benabel
Copy link
Contributor

@benabel benabel commented Dec 19, 2024

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

This package is compatible with new versions of remark.

This package is compatible with new versions of remark.

Signed-off-by: Benjamin Abel <[email protected]>
@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Dec 19, 2024

This comment has been minimized.

@wooorm
Copy link
Member

wooorm commented Jan 1, 2025

Please look at the tests. Thank you

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Jan 2, 2025
Signed-off-by: Benjamin Abel <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (a185821) to head (949215f).
Report is 29 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1394   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          142       138    -4     
=========================================
- Hits           142       138    -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Benjamin Abel <[email protected]>
Copy link
Contributor Author

@benabel benabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wooorm I removed link to pandoc docs to fit into 80 chars line length.

@wooorm wooorm merged commit 7bd0191 into remarkjs:main Jan 2, 2025
4 checks passed
@wooorm
Copy link
Member

wooorm commented Jan 2, 2025

Thanks! :)

@wooorm wooorm added 📚 area/docs This affects documentation 💪 phase/solved Post is done labels Jan 2, 2025

This comment has been minimized.

@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 area/docs This affects documentation 💪 phase/solved Post is done
Development

Successfully merging this pull request may close these issues.

3 participants