Skip to content

Memoize the processor in MarkdownHooks #909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 21, 2025
Merged

Memoize the processor in MarkdownHooks #909

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
089a5e7
Memoize the processor in MarkdownHooks
remcohaszing Apr 18, 2025
087408f
Replace arrow function with a function expression
remcohaszing Apr 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions lib/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ import {unreachable} from 'devlop'
import {toJsxRuntime} from 'hast-util-to-jsx-runtime'
import {urlAttributes} from 'html-url-attributes'
import {Fragment, jsx, jsxs} from 'react/jsx-runtime'
import {useEffect, useState} from 'react'
import {useEffect, useMemo, useState} from 'react'
import remarkParse from 'remark-parse'
import remarkRehype from 'remark-rehype'
import {unified} from 'unified'
Expand Down Expand Up @@ -212,7 +212,10 @@ export async function MarkdownAsync(options) {
* React node.
*/
export function MarkdownHooks(options) {
const processor = createProcessor(options)
const processor = useMemo(
() => createProcessor(options),
Copy link
Member

@wooorm wooorm Apr 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use a regular function, thanks

[options.rehypePlugins, options.remarkPlugins, options.remarkRehypeOptions]
)
const [error, setError] = useState(
/** @type {Error | undefined} */ (undefined)
)
Expand All @@ -238,12 +241,7 @@ export function MarkdownHooks(options) {
cancelled = true
}
},
[
options.children,
options.rehypePlugins,
options.remarkPlugins,
options.remarkRehypeOptions
]
[options.children, processor]
)

if (error) throw error
Expand Down