Skip to content

Add MarkdownHooks fallback prop #897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 7, 2025
Merged

Add MarkdownHooks fallback prop #897

merged 2 commits into from
Mar 7, 2025

Conversation

remcohaszing
Copy link
Member

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

The <MarkdownHooks/> component now supports a new prop named fallback. This fallback is displayed while the initial content hasn’t loaded yet. The name fallback was chosen to match the same prop from <Suspense/>.

@remcohaszing
Add MarkdownHooks fallback prop
a02a273 
The `<MarkdownHooks/>` component now supports a new prop named
`fallback`. This fallback is displayed while the initial content hasn’t
loaded yet. The name `fallback` was chosen to match the same prop from
`<Suspense/>`.
@remcohaszing remcohaszing added 🗄 area/interface This affects the public interface 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have 🤞 phase/open Post is being triaged manually labels Mar 5, 2025
wooorm
wooorm reviewed Mar 7, 2025
View reviewed changes
Copy link
Member

@wooorm wooorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to write docs for features

@wooorm wooorm merged commit 939c667 into main Mar 7, 2025
2 checks passed
@wooorm wooorm deleted the loading-fallback branch March 7, 2025 10:01
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@wooorm wooorm added the 💪 phase/solved Post is done label Mar 7, 2025
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Mar 7, 2025
@wooorm
Copy link
Member

wooorm commented Mar 7, 2025

Released in 10.1.0, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wooorm wooorm wooorm left review comments

Assignees

No one assigned

Labels

🗄 area/interface This affects the public interface 💪 phase/solved Post is done 🧒 semver/minor This is backwards-compatible change 🦋 type/enhancement This is great to have

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@remcohaszing @wooorm