refactor(events): optimize perf and move setCamPos from player to cur…

…sors
remarkablegames · Jan 22, 2025 · 0f00bee · 0f00bee
1 parent 0878b8f
commit 0f00bee
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/src/events/cursors.ts b/src/events/cursors.ts
@@ -9,22 +9,30 @@ export function addCursorKeys(player: Player) {
       case 'left':
       case 'a':
         player.move(-SPEED, 0)
+        setCameraPosition(player)
         break
 
       case 'right':
       case 'd':
         player.move(SPEED, 0)
+        setCameraPosition(player)
         break
 
       case 'up':
       case 'w':
         player.move(0, -SPEED)
+        setCameraPosition(player)
         break
 
       case 'down':
       case 's':
         player.move(0, SPEED)
+        setCameraPosition(player)
         break
     }
   })
 }
+
+function setCameraPosition(player: Player) {
+  setCamPos(player.worldPos()!)
+}
diff --git a/src/gameobjects/player.ts b/src/gameobjects/player.ts
@@ -13,10 +13,6 @@ export function addPlayer(x = center().x, y = center().y) {
     Tag.Player,
   ])
 
-  player.onUpdate(() => {
-    setCamPos(player.worldPos()!)
-  })
-
   addCursorKeys(player)
 
   const attack = new Attack(player)