fix(ISV-6436): update metadata to support older Python versions#8
Merged
BorekZnovustvoritel merged 3 commits intomainfrom Feb 16, 2026
Merged
fix(ISV-6436): update metadata to support older Python versions#8BorekZnovustvoritel merged 3 commits intomainfrom
BorekZnovustvoritel merged 3 commits intomainfrom
Conversation
BorekZnovustvoritel
force-pushed
the
ISV-6436
branch
2 times, most recently
from
227b486 to
45e2217
Compare
Signed-off-by: Marek Szymutko <mszymutk@redhat.com>
Signed-off-by: Marek Szymutko <mszymutk@redhat.com>
Signed-off-by: Marek Szymutko <mszymutk@redhat.com>
BorekZnovustvoritel
force-pushed
the
ISV-6436
branch
from
45e2217 to
05acd0b
Compare
| TopicPartition( | ||
| topic=partition_info.topic, | ||
| partition=partition_info.partition, | ||
| offset=max_to_commit + 1, |
Contributor
Author
There was a problem hiding this comment.
These changes look weird, let me explain:
- Kafka needs message commits to be +1 than the latest confirmed messages
- In the past, the tracker class had the exact values of offsets from messages
- Now that I added the commit retry, there is a chance we may need to return commits back to the tracker class. I think it's cleaner to add the +1 when the offset is first stored in the tracker object, because otherwise the retry (re-register) of commits needs to again subtract the -1.
This changes the behavior of the tracker class slightly, but it was never meant to be used directly, it's just called from the BaseConsumer where it's a private attribute.
tomasbakk
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is meant to be reviewed per commit. But all these changes are related as the problems started manifesting with the bump of
confluent_kafka.