Skip to content

Rel 821549 newtonsoft update #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
TommyBigNose wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Rel 821549 newtonsoft update #31

TommyBigNose wants to merge 8 commits into from

Conversation

@TommyBigNose
Copy link
Contributor

@TommyBigNose TommyBigNose commented Feb 20, 2023

No description provided.

@mjelwood
Copy link
Collaborator

mjelwood commented Feb 20, 2023

@TommyBigNose How good are the tests associated with this process? is there any CI/CD associated with it? I don't see any build pipelines linked in the checks section

@mjelwood
Copy link
Collaborator

mjelwood commented Feb 20, 2023

after merge does this publish to microsoft as a update to https://marketplace.visualstudio.com/items?itemName=RelativityODA.RelativityTemplates?

@mjelwood
Copy link
Collaborator

mjelwood commented Feb 20, 2023

Do we need to update the change log with details? and the .github/codeowners?

@TommyBigNose
Copy link
Contributor Author

TommyBigNose commented Feb 20, 2023

@TommyBigNose How good are the tests associated with this process? is there any CI/CD associated with it? I don't see any build pipelines linked in the checks section

Hey @mjelwood , this is DevEx baby! No CI/CD on this and no tests

@TommyBigNose
Copy link
Contributor Author

TommyBigNose commented Feb 20, 2023

Do we need to update the change log with details? and the .github/codeowners?

Yeah we have one, I can update it soon

@TommyBigNose
Copy link
Contributor Author

TommyBigNose commented Feb 20, 2023

after merge does this publish to microsoft as a update to https://marketplace.visualstudio.com/items?itemName=RelativityODA.RelativityTemplates?

No, that has to be a manual release haha

@mjelwood
Copy link
Collaborator

mjelwood commented Feb 20, 2023

@TommyBigNose How good are the tests associated with this process? is there any CI/CD associated with it? I don't see any build pipelines linked in the checks section

Hey @mjelwood , this is DevEx baby! No CI/CD on this and no tests

Can we manually test this new vsix works then? and provide evidence that the supported versions of Visual Studio won't have issues with the updated packages then?

@mjelwood
Copy link
Collaborator

mjelwood commented Feb 20, 2023

(https://github.com/relativitydev/relativity-templates/tree/develop/Source/VSIX/AllRelativityTemplates/packages)

Should we remove the old unsupported newtonsoft files here?

mjelwood
mjelwood requested changes Feb 20, 2023
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjelwood mjelwood mjelwood requested changes

@relthorbiedrzycki relthorbiedrzycki Awaiting requested review from relthorbiedrzycki relthorbiedrzycki was automatically assigned from relativitydev/eventing-messaging-reldev

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TommyBigNose @mjelwood @ppande1020