Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually install at dependency #30

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Manually install at dependency #30

merged 1 commit into from
Mar 24, 2023

Conversation

andodet
Copy link
Contributor

@andodet andodet commented Mar 24, 2023

Newer Ubuntu versions (e.g 22.04) don't offer at preinstalled, which is used by the teardown script. We need to install it manually in order not to break on Ubuntu releases.

As #22, this also adds the boot_disk_type optional argument.

@andodet
Manually install at
c3351b9 
Newer Ubuntu versions (e.g 22.04) don't offer `at` preinstalled, which
is used by the teardown script. We need to install it manually in order
not to break on Ubuntu releases.
@andodet andodet changed the title Manually install at Manually install at dependency Mar 24, 2023
ravwojdyla
ravwojdyla approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@ravwojdyla ravwojdyla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andodet thanks a lot! In general I would love to remove the use of at, maybe related #29 and #28. But that's obviously out of the scope of this PR.

@ravwojdyla ravwojdyla merged commit e578a77 into related-sciences:main Mar 24, 2023
@ravwojdyla ravwojdyla mentioned this pull request Mar 24, 2023
Closed
@andodet andodet deleted the install-at branch March 24, 2023 22:00
@andodet
Copy link
Contributor Author

andodet commented Mar 24, 2023

Thanks for merging this so quickly. It would be great if you could create a release so that using uses: related-sciences/[email protected] pulls the latest version.

@ravwojdyla
Copy link
Contributor

@andodet done, v0.5 released: https://github.com/related-sciences/gce-github-runner/releases/tag/v0.5

@andodet
Copy link
Contributor Author

andodet commented Mar 25, 2023

thanks a lot! In general I would love to remove the use of at, maybe related #29 and #28. But that's obviously out of the scope of this PR.

@ravwojdyla Eliminating the need for external dependencies would be better, this can be probably solved with a bit of crontab wizardry (going to experiment with it once I've got some time).

@ravwojdyla
Copy link
Contributor

@andodet thanks, would love that 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravwojdyla ravwojdyla ravwojdyla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andodet @ravwojdyla