set text-decoration to none if no styles are provided when using the append property #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
I found a bug where there's a trailing space at the end of the header when using the
append
property. This shows up as an underscore because of text decoration. I have put all the details in #26.This PR is trying to patch this by setting it to none when no styles are passed and that seems to be fixing the issue. However, I admit I haven't worked with serious JS code for quite some time and I might be a little rusty. There's probably a better way to solve this.