Skip to content

Conversation

rishichawda
Copy link

@rishichawda rishichawda commented Oct 3, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

I found a bug where there's a trailing space at the end of the header when using the append property. This shows up as an underscore because of text decoration. I have put all the details in #26.

This PR is trying to patch this by setting it to none when no styles are passed and that seems to be fixing the issue. However, I admit I haven't worked with serious JS code for quite some time and I might be a little rusty. There's probably a better way to solve this.

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Oct 3, 2025
Copy link

github-actions bot commented Oct 3, 2025

Hi! It seems some of the things asked in the template are missing? Please edit your post to fill out everything.

  • Initial checklist (todo)
  • Description of changes

You won’t get any more notifications from me, but I’ll keep on updating this comment, and remove it when done!

If you need it, here’s the original template
<!--
  Please check the needed checkboxes ([ ] -> [x]).
  Leave the comments as they are: they do not show on GitHub.

  Please try to limit the scope,
  provide a general description of the changes,
  and remember it’s up to you to convince us to land it.

  We are excited about pull requests.
  Thank you!
-->

### Initial checklist

* [ ] I read the support docs <!-- https://github.com/rehypejs/.github/blob/main/support.md -->
* [ ] I read the contributing guide <!-- https://github.com/rehypejs/.github/blob/main/contributing.md -->
* [ ] I agree to follow the code of conduct <!-- https://github.com/rehypejs/.github/blob/main/code-of-conduct.md -->
* [ ] I searched issues and discussions and couldn’t find anything or linked relevant results below <!-- https://github.com/search?q=user%3Arehypejs&type=issues and https://github.com/orgs/rehypejs/discussions -->
* [ ] I made sure the docs are up to date
* [ ] I included tests (or that’s not needed)

### Description of changes

TODO

<!--do not edit: pr-->

Thanks,
— bb

@github-actions github-actions bot added 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Oct 3, 2025
@wooorm
Copy link
Member

wooorm commented Oct 5, 2025

You are adding styles for everyone, a breaking change, which probably not everyone wants.
Probably not the best solution for your problem?

@rishichawda
Copy link
Author

@wooorm Yeah that's why I wrote in my PR description that there is probably a better way to solve this. I tried finding where the trailing space is coming from but I don't see it in output html.

@rishichawda
Copy link
Author

I found out where the space was coming from #26 (comment)

@rishichawda rishichawda closed this Oct 6, 2025
@rishichawda rishichawda deleted the fix-trailing-underscore-when-using-append-option branch October 6, 2025 02:56

This comment has been minimized.

@wooorm wooorm added the 🤷 no/invalid This cannot be acted upon label Oct 6, 2025
@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 🤞 phase/open Post is being triaged manually labels Oct 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤷 no/invalid This cannot be acted upon 👎 phase/no Post cannot or will not be acted on

Development

Successfully merging this pull request may close these issues.

2 participants