-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ecocredit table with ghost credits on first page #2176
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Would it be tricky to just display the page(s) with some data in this case (dropping the first empty one)? |
We have no way of knowing on which page we will have data beforehand, unfortunately (there could be several empty pages). |
I see, I guess we just have to live with it then until this is fixed on regen ledger side eventually: regen-network/regen-ledger#1889 cc/ @erikalogie @ryanchristo |
is there an address that we can use to test this on redwood? |
@blushi not to my knowledge, unfortunately. |
@flagrede can we update this to display 10 items per page by default as discussed last week? |
50bee00
to
ce881bb
Compare
Description
Closes: #2097
The problem here was, for this specific account on main net, about ghost credits (empty balances on credits that used to have one returned by the ledger). We took the decision to hide those ghost credits before so we ended up with a first page without credit and the empty state was displayed for that reason.
In this PR we display the table if there are no rows on the first page but the table has more pages.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...