-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: pagination credit batches #1906
Conversation
@erikalogie you can check the pagination bug fix here: https://deploy-preview-1906--regen-registry.netlify.app/ecocredits/accounts/regen1df675r9vnf7pdedn4sf26svdsem3ugavgxmy46/portfolio |
@flagrede this looks good. As you said on slack the rest will be solved with the ledger upgrade |
@wgwz You're missing some context for this issue I think. The initial issue was that the ledger is sending us ecocredits that used to have balance but do not anymore. We wanted to hide these "ghost" credits from the user so we filter them on the front end. This created an inconsistency with pages having "ghost" credits, we were having labels like "21-25" while displaying only 4 rows for example. This PR just takes into account those "ghost" credits to adjust the pagination label accordingly. Eventually, this issue will be solved on the ledger side, in the meantime we try to accommodate it as best as we can. |
@wgwz see underlying issue on regen-ledger: regen-network/regen-ledger#1889 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
Description
Closes: regen-network/rnd-dev-team#1662
Remove hidden from current pagination count.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
21-24
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...