-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: minimal ts erros for group-ui imports #79
Conversation
3b2ba0f
to
9f5a846
Compare
This is not the ideal solution but I think we should tag another alpha version with the changes here so that we can at least get the groups ui working with amino support in the meantime while continuing to investigate a solution to #84. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pulled this locally, then run yarn build
and then using yarn link
to use my local version of @regen-network/api in groups-ui ryan/10-amino-signing-support
but I still get typescript errors in dev
or build
...
Maybe I have something wrong in my set up or I've missed a step, I haven't dug too much into it at this point.
Other than that I'm fine with those changes so we can move forward with that, as long as we add a note in the README about that, so pre-approving.
Hmm... I'm not sure. I was importing the local package in If you run
Note added 28a68b2 |
It might also have been |
This pull request includes minimal typescript fixes needed for the amino signing support solution in groups-ui:
This is only a temporary fix and generating the code will overwrite the changes here but this would unblock us from adding amino signing support to the groups-ui.