feat: add bridge_amino and test #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhagel
commented
Nov 29, 2022
| }); | ||
|
|
||
| await runAminoTest(msgClient, TEST_MSG_BRIDGE); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
I have tested this against redwood locally, including all negative tests I could think of, but we will need to implement #59 to run it in CI.
https://redwood.regen.aneka.io/txs/C70A43E236BAAB1B2DD2D352A03CBB72D8DF307EB7F03D61905315B26324C738
mhagel
commented
Nov 29, 2022
| @@ -25,7 +25,7 @@ import { | |||
| } from '../generated/regen/ecocredit/marketplace/v1/tx'; | |||
| import { GeneratedType } from '@cosmjs/proto-signing'; | |||
|
|
|||
| const ecocreditRegistry: Array<[string, GeneratedType]> = [ | |||
| const ecocreditRegistry: ReadonlyArray<[string, GeneratedType]> = [ | |||
There was a problem hiding this comment.
ReadonlyArray is more in line with the established convention for type registries.
mhagel
requested review from
blushi and
a team
and removed request for
blushi
blushi
reviewed
Nov 30, 2022
packages/api/src/tx/msg.ts
Outdated
Comment on lines
40
to
42
| regenTypeRegistry.forEach(([key, value]) => { | ||
| customRegistry.push([`/${key}`, value]); | ||
| }); |
There was a problem hiding this comment.
not related to this PR, but why do we need this?
messageTypeRegistry.forEach above is already registering all the types
mhagel
commented
Nov 30, 2022
| @@ -37,9 +36,6 @@ export async function setupTxExtension( | |||
| messageTypeRegistry.forEach((value, key) => { | |||
| customRegistry.push([`/${key}`, value]); | |||
| }); | |||
| regenRegistry.forEach(([key, value]) => { | |||
There was a problem hiding this comment.
deleting this. As @blushi pointed out, the messageTypeRegistry already registers all the custom regen msgs.
blushi
approved these changes
Dec 1, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #60