-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BT01 schemas #28
base: semantic-enumerations
Are you sure you want to change the base?
Add BT01 schemas #28
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@S4mmyb just opening a draft so we can use comments to chat discuss further changes to this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@S4mmyb right now this is the BT01 credit class file you had started, except I have modified the ranges to be valid and work with linkml. The issue was we had ranges like schema:Duration
and URL
, but ranges need to be proper data types that linkml understands OR custom data classes.
I'm still not sure what our best option is for specifying a ISO 8601 Duration datatype. I wonder if this might be an easy contribution to LinkML core data types (they have other 8601 date/time types). Or, for now I have specified this in the description eg "Crediting term duration for the project. An ISO 8601 duration.".
SDGs: | ||
description: List of relevant Sustainable Development Goals for this impact. | ||
range: SDG | ||
multivalued: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@S4mmyb currently SDGs
as a slot name doesn't fit our linkml linting configuration (slots should be lower camel case). What about just SDG
?
In the past I have tried to avoid using plural wording for technical properties and just stick with singular words everywhere, knowing that some singular properties might indeed have mutliple values, thinking that the schema will specify if they are multi-valued, not the naming itself. Curious what you think about this more generally.
@@ -18,7 +18,7 @@ default_range: string | |||
classes: | |||
TerrasosProjectInfo: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops I need to rename this
TerrasosProjectInfo: | |
BT01ProjectInfo: |
default_curi_maps: | ||
- semweb_context | ||
default_prefix: rfs | ||
default_range: string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the default range is string
I don't think we need to specify range: string
below on individual slots
WIP PR to add schemas for BT01 credit class + project + batches in
schemas/src/BT01
directory