Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tx hash to retirements table #20

Merged
merged 1 commit into from
Jul 6, 2023
Merged

feat: add tx hash to retirements table #20

merged 1 commit into from
Jul 6, 2023

Conversation

wgwz
Copy link
Contributor

@wgwz wgwz commented Jul 6, 2023

Closes: regen-network/rnd-dev-team#1753

This adds the tx hash to each row in the retirements table.
This is done in such a way where it can be re-used in the future.
I.e. we can include the tx hash in the proposals PR as well.

@wgwz wgwz requested review from blushi and ryanchristo July 6, 2023 11:15
@wgwz
Copy link
Contributor Author

wgwz commented Jul 6, 2023

One thing to note is that either we need an additional/modified migration or as part of deploying this we could truncate the retirements table.
The problem is that the new tx hash column needs to be populated with correct data.
I'd suggest truncating the retirements table before applying the migration in this PR and deploying.
It's a simple approach with little downsides, it would take a couple of minutes for all retirements to be reindexed.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truncating the retirements table sounds fine to me

@wgwz wgwz merged commit f28a200 into main Jul 6, 2023
@wgwz wgwz deleted the kyle/1753-tx-hash branch July 6, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add txHash to indexed retirements
2 participants