Skip to content

Login page - #26

Open
Bartzi wants to merge 4 commits into
masterfrom
login_page
Open

Login page#26
Bartzi wants to merge 4 commits into
masterfrom
login_page

Conversation

@Bartzi

@Bartzi Bartzi commented Dec 18, 2015

Copy link
Copy Markdown
Contributor

adds possibility for users to login locally. Uses the oauth integration in the backend as described by
this PR.

It might need some more test but I'm not sure what kind of tests... I just have such a feeling ;)

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd make the buttons equally large and take the whole width on a mobile screen for consistency and and fat fingers 😉 . col-xs-3 col-sm-3 col-md-2 and changing the button width to 100%.

@dahoo

dahoo commented Dec 18, 2015

Copy link
Copy Markdown
Member

Great! Please use locale strings instead of English words.

@Bartzi

Bartzi commented Dec 20, 2015

Copy link
Copy Markdown
Contributor Author

okay I've done everything you mentioned... but I'm not really able to add locale strings as placeholder for the inputs... do you have an idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants