Actually make sleepBeforeConnect() implement an exponential backoff#99
Merged
Actually make sleepBeforeConnect() implement an exponential backoff#99
Conversation
Member
|
I am happy to merge this as it is. I think we should consider adding config values to replace the constants (25 for the ramp, and 15s for max in this PR). These could even potentially go into the clientconf as a deployment setting so that clients have a more easily tunable backoff if things start to get overwhelmed. We might open an issue for that relating to #100 |
jmwample
approved these changes
Oct 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, our sleepBeforeConnect() doesn't sleep for the first 6 connections, but then sleeps 1 second between retries after that.
That's too overwhelming, and not an exponential backoff. This change increases the exponential backoff to be 25*(2^n) milliseconds, up to 15 seconds, for retry n.
We may want to even increase the upper bound (15 seconds) to something larger (or remove the upper bound entirely)