Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][ENG-4134]Allow specifying custom app module in rxconfig #4556

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[WIP][ENG-4134]Allow specifying custom app module in rxconfig #4556

wants to merge 3 commits into from
+48 −4

Conversation

ElijahAhianyo
Copy link
Collaborator 

import reflex as rx

config = rx.Config(
    app_name="my_project",
    app_module_path="/path/to/another/app/module.py"
)

@linear Linear
Copy link

linear bot commented Dec 18, 2024

ENG-4134 Allow specifying app instance in rxconfig.py

ElijahAhianyo
ElijahAhianyo commented Dec 18, 2024
View reviewed changes
reflex/config.py
@property
def module(self) -> str:
"""Get the module name of the app.

Returns:
The module name.
"""
if self.app_module:
return f"{Path(self.app_module.__file__).parent.name}.{Path(self.app_module.__file__).stem}"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wondering if this is what we should be doing. Or should we return the absolute path here? Im trying to think of where doing it like this could pose a real problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ElijahAhianyo