fix(core): sync url params with internal state for useTable hook
#6645
+215
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reset filters and sorters used in tables on URL query clear
Co-authored-by: Batuhan Wilhelm <[email protected]>
- prevent watched url filters from being early triggered by change to url by internal filter
🦋 Changeset detectedLatest commit: 5462d85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for refine-doc-live-previews ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
In the
useTablehook, when there are internal state changes it can update URL state, but it doesn't work in the reverse. This leads to some edge cases where a change in the url doesn't affect the table.What is the new behavior?
There is now watcher useEffect that checks if the URL and internal are in sync before making the necessary updates.
fixes (issue)
#6300
Notes for reviewers
There is currently a bug I need assistance with to get the feature completed, as detailed here
This would be a continuation of fix(core): reset table filters and sorters on current page re-navigate via side-nav #6389 as I couldn't re-open it.