Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(win95): update supported dimensions #5932

Merged
merged 11 commits into from
May 9, 2024

Conversation

alicanerdurmaz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

Bugs / Features

What is the new behavior?

app minimum width set to 1200px

@alicanerdurmaz alicanerdurmaz requested a review from a team as a code owner May 8, 2024 14:26
Copy link

changeset-bot bot commented May 8, 2024

⚠️ No Changeset found

Latest commit: 32c6880

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented May 8, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 32c6880. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

@aliemir aliemir changed the title fix(win95): set app width to 1200px fix(win95): update supported dimensions May 8, 2024
@aliemir
Copy link
Member

aliemir commented May 8, 2024

Just sent a commit here, updated the dimensions for smaller sizes and tested them. Added checks for height as well and updated the displayed text on unsupported sizes.

localhost_5173_video-club

Copy link

netlify bot commented May 9, 2024

Deploy Preview for refine-video-club ready!

Name Link
🔨 Latest commit 32c6880
🔍 Latest deploy log https://app.netlify.com/sites/refine-video-club/deploys/663cb5d964fa8f0008b90381
😎 Deploy Preview https://deploy-preview-5932--refine-video-club.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@refine-bot
Copy link
Contributor

Images automagically compressed by Calibre's image-actions

Compression reduced images by 31%, saving 107 bytes.

Filename Before After Improvement Visual comparison
examples/win95/public/images/error-icon.png 345 bytes 238 bytes -31.0% View diff

198 images did not require optimisation.

@aliemir aliemir merged commit 39295e9 into master May 9, 2024
22 checks passed
@aliemir aliemir deleted the fix/set-win95-app-width-to-1200px branch May 9, 2024 12:03
@BatuhanW BatuhanW added this to the June Release milestone May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants