Skip to content

fix(web): hide private visibility option when workspace doesn't support it#2117

Draft
soneda-yuya wants to merge 1 commit intomainfrom
fix/project-visibility-private-option
Draft

fix(web): hide private visibility option when workspace doesn't support it#2117
soneda-yuya wants to merge 1 commit intomainfrom
fix/project-visibility-private-option

Conversation

@soneda-yuya
Copy link
Copy Markdown
Contributor

Summary

  • Hide the "Private" option in the project visibility selector when the workspace policy doesn't allow private projects
  • Previously, the option was visible but the disabled property wasn't being passed to the SelectField component

What I've done

  • Modified ProjectVisibilityModal.tsx to conditionally include the private option only when enableToCreatePrivateProject is true

What I haven't done

  • No changes to the SelectField or Selector components to support disabled options

How I tested

  • Manual testing required

Which point I want you to review particularly

  • The filtering logic for projectVisibilityOptions

Memo

  • The Confirm button still has a safety check for projectVisibility === "private" && !enableToCreatePrivateProject

Checklist

  • Verified backward compatibility related to feature modifications
  • Confirmed backward compatibility for migrations
  • Verified that no personally identifiable information (PII) is included

🤖 Generated with Claude Code

…rt it

The SelectField component doesn't support disabled options, so instead
of showing a disabled "Private" option, we now completely hide it when
the workspace policy doesn't allow private projects.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

🚀 Cloud Run Preview Deployed

🔗 Click here to open the preview in a new tab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant