fix(web): hide private visibility option when workspace doesn't support it#2117
Draft
soneda-yuya wants to merge 1 commit intomainfrom
Draft
fix(web): hide private visibility option when workspace doesn't support it#2117soneda-yuya wants to merge 1 commit intomainfrom
soneda-yuya wants to merge 1 commit intomainfrom
Conversation
…rt it The SelectField component doesn't support disabled options, so instead of showing a disabled "Private" option, we now completely hide it when the workspace policy doesn't allow private projects. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
🚀 Cloud Run Preview Deployed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disabledproperty wasn't being passed to the SelectField componentWhat I've done
ProjectVisibilityModal.tsxto conditionally include the private option only whenenableToCreatePrivateProjectis trueWhat I haven't done
SelectFieldorSelectorcomponents to support disabled optionsHow I tested
Which point I want you to review particularly
projectVisibilityOptionsMemo
projectVisibility === "private" && !enableToCreatePrivateProjectChecklist
🤖 Generated with Claude Code