[v25.2.x] dl/coordinator: add default formatter for errc#31004
Open
vbotbuildovich wants to merge 1 commit into
Open
[v25.2.x] dl/coordinator: add default formatter for errc#31004vbotbuildovich wants to merge 1 commit into
vbotbuildovich wants to merge 1 commit into
Conversation
This errc gets serialized over the wire, so it's possible for a binary to get unknown numeric values (e.g. future errors). The formatter previously didn't account for this and would result in UB when adding errc types. (cherry picked from commit a9b2926)
Collaborator
Author
CI test resultstest results on build#86681
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #31003
Conflict details
errcformatting to an inlineformat_toin the header, but v25.2.x still declaresoperator<<in the header and implements it intypes.cc. Kept the target branch'soperator<<declaration in the header and applied the commit's intent — anerrc::unknown(N)fallback for out-of-range wire-deserialized values — as adefault:case in theoperator<<switch insrc/v/datalake/coordinator/types.cc.