[v25.3.x] cluster: catch exceptions in sync_kafka_start_offset_override() & fetch path#30112
Open
vbotbuildovich wants to merge 4 commits into
Open
Conversation
Calls made to `log_eviction_stm` and `archival_metadata_stm` within this function can throw various exceptions (`timed_out`, shutdown exceptions). These propagate as exceptional futures through `validate_fetch_offset()` into the fetch handler's `max_concurrent_for_each()` loop, causing an entire multi-partition fetch request to fail when only one partition has an error. Wrap the coroutine body in a try-catch so that exceptions are returned as result errors instead. Shutdown exceptions map to `errc::shutting_down` and all other exceptions map to `errc::timeout`, ensuring that a failure in the fetch path for a single partition will _only_ affect the single partition's response. (cherry picked from commit e0d881c)
(cherry picked from commit 782b29a)
Anything is better than holding client connections open and never returning a response here. Also remove a now redundant exception handling location for a call to `read_from_partition()` (cherry picked from commit bb12c1a)
To make this version of the function call more similar to future versions, enabling the previous test to fail.
Collaborator
Author
CI test resultstest results on build#83088
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of PR #30097