Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix links #970

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Fix links #970

merged 1 commit into from
Jan 29, 2025

Conversation

JakeSCahill
Copy link
Contributor

@JakeSCahill JakeSCahill commented Jan 29, 2025

Description

Fixes broken links that were introduced in:

The files that were changed are single-sourced into the Cloud docs and the Connect docs. As some of the links introduced do not exist in those doc-sets, the links broke.

To avoid this in the future, we can:

  • Make sure to always check the deploy logs before merging.
  • Always run the build locally before pushing to GitHub.
  • Add more comments to single-sourced docs to clarify that care must be taken when adding new links.

Page previews

Checks

  • New feature
  • Content gap
  • Support Follow-up
  • Small fix (typos, links, copyedits, etc)

@JakeSCahill JakeSCahill requested a review from a team as a code owner January 29, 2025 11:18
Copy link

netlify bot commented Jan 29, 2025

Deploy Preview for redpanda-docs-preview ready!

Name Link
🔨 Latest commit b4093b4
🔍 Latest deploy log https://app.netlify.com/sites/redpanda-docs-preview/deploys/679a0e8f4a617900081e1dcf
😎 Deploy Preview https://deploy-preview-970--redpanda-docs-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@asimms41 asimms41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JakeSCahill JakeSCahill merged commit f990067 into main Jan 29, 2025
7 checks passed
@JakeSCahill JakeSCahill deleted the link-fixes branch January 29, 2025 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants