Iceberg troubleshooting and performance tuning for Cloud#565
Conversation
✅ Deploy Preview for rp-cloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
📝 WalkthroughWalkthroughThis pull request updates the Antora documentation configuration and navigation by switching the included branch from Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
local-antora-playbook.yml (1)
18-18: Revert this branch pin before merge.Using the feature branch is fine for preview, but please switch this back to
mainbefore merging to avoid stale local build config after the docs PR branch is removed.Based on learnings: in this docs workflow,
local-antora-playbook.ymlis temporarily pointed at companion docs branches for preview and then reverted tomainbefore merge.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@local-antora-playbook.yml` at line 18, The branches array in local-antora-playbook.yml is temporarily pinned to the feature branch DOC-1848-Document-feature-Iceberg-stress-testing; change that entry back to main by replacing that branch name with main in the branches list (the line containing "branches: [DOC-1848-Document-feature-Iceberg-stress-testing, v/*, shared, site-search]" should read with main instead of the feature branch) so the playbook uses the main companion docs branch before merging.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@local-antora-playbook.yml`:
- Line 18: The branches array in local-antora-playbook.yml is temporarily pinned
to the feature branch DOC-1848-Document-feature-Iceberg-stress-testing; change
that entry back to main by replacing that branch name with main in the branches
list (the line containing "branches:
[DOC-1848-Document-feature-Iceberg-stress-testing, v/*, shared, site-search]"
should read with main instead of the feature branch) so the playbook uses the
main companion docs branch before merging.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: edc606fb-b0a6-4180-b21b-196a65fe4e06
📒 Files selected for processing (3)
local-antora-playbook.ymlmodules/ROOT/nav.adocmodules/manage/pages/iceberg/iceberg-troubleshooting.adoc
|
@kbatuigas should you add a blurb for this to the Cloud What's New, so users know about it? |
|
@kbatuigas before you merge 1599, please doublecheck for build errors; e.g., the Troubleshoot errors link here: https://deploy-preview-565--rp-cloud.netlify.app/redpanda-cloud/manage/iceberg/migrate-to-iceberg-topics/#troubleshoot-common-migration-issues |
micheleRP
left a comment
There was a problem hiding this comment.
please see my suggestions before merging
We'll leave it out of What's New in Cloud, we haven't added this to What's New in Self-managed either since there are no new features added. |
Description
Related PR: redpanda-data/docs#1599 (single sourced)
This pull request adds new documentation for Iceberg topics, specifically focusing on performance tuning and troubleshooting. It also updates the navigation and Antora playbook to include these new resources and a relevant documentation branch.
New Iceberg documentation:
modules/manage/pages/iceberg/iceberg-performance-tuning.adoc)modules/manage/pages/iceberg/iceberg-troubleshooting.adoc)Navigation updates:
modules/ROOT/nav.adoc)Antora playbook update:
local-antora-playbook.yml)Resolves https://github.com/redpanda-data/documentation-private/issues/
Review deadline:
Page previews
https://deploy-preview-565--rp-cloud.netlify.app/redpanda-cloud/manage/iceberg/iceberg-performance-tuning/
https://deploy-preview-565--rp-cloud.netlify.app/redpanda-cloud/manage/iceberg/iceberg-troubleshooting/
Checks