Conversation
…y parameters by using a dictionary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Filipe,
I wanted to simplify the code a bit. Lets discuss this next time?
Some functions were way too long and hard to efficiently follow.
I made main() and blocking_read() much more manageable. And I would like to do a bit more in the same direction with the rest of the code if you agree.
Long term, after simplifying enough, ideally I think we should get rid of the stand_alone_runner and just have an option for the self_contained_coordinator to do that. Currently they are just sharing 80% of the code ...
Lets discuss it.