Align Search APIs and behaviour with Redis 8.0+ #4173
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uglide
force-pushed
the
imalinovskyi_keyless_command_execution
branch
from
85ff14f to
f85344a
Compare
uglide
changed the title
uglide
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR aligns various Redis search APIs with Redis 8.0+ policies by introducing a new keyless command execution method, implementing round‑robin distribution for keyless commands in cluster mode, and replacing legacy search iteration APIs with a more robust AggregateIterator. Key changes include the introduction of executeKeylessCommand, removal of JedisBroadcastAndRoundRobinConfig, and the implementation of round‑robin scheduling in ClusterCommandExecutor.
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/test/java/redis/clients/jedis/modules/search/AggregateIteratorTest.java | New tests for AggregateIterator covering basic use, cursor removal and error cases |
| src/main/java/redis/clients/jedis/search/aggr/AggregationBuilder.java | Adds cursorCount tracking when using cursor-based aggregation |
| src/main/java/redis/clients/jedis/search/aggr/AggregateIterator.java | Implements a new iterator for aggregation results with proper cursor management |
| src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java | Introduces round‑robin distribution for keyless command execution |
| src/main/java/redis/clients/jedis/UnifiedJedis.java | Updates search commands to use the new executeKeylessCommand method and deprecates legacy APIs |
| src/main/java/redis/clients/jedis/CommandObjects.java | Adjusts round‑robin command routing logic and removes unused configuration |
Comments suppressed due to low confidence (1)
src/main/java/redis/clients/jedis/CommandObjects.java:3443
- [nitpick] Add a comment explaining why certain SearchCommands (SUGGET, SUGADD, SUGLEN, SUGDEL, CURSOR) are excluded from round-robin routing to aid future maintainers.
private boolean isRoundRobinSearchCommand(SearchCommand sc) {
src/main/java/redis/clients/jedis/executors/ClusterCommandExecutor.java
Outdated
Show resolved
Hide resolved
ggivo
added
the
breakingchange
uglide
force-pushed
the
imalinovskyi_keyless_command_execution
branch
from
7145811 to
c9812a6
Compare
uglide
force-pushed
the
imalinovskyi_keyless_command_execution
branch
from
0de5b8f to
b03ef67
Compare
- Introduce executeKeylessCommand - Implement round-robin execution in ClusterCommandExecutor - Update search commands according to the latest request/response policies - Remove JedisBroadcastAndRoundRobinConfig - Introduce AggregateIterator for proper Cluster support - Deprecate APIs that rely on legacy RediSeach behaviour
uglide
force-pushed
the
imalinovskyi_keyless_command_execution
branch
from
b03ef67 to
3e38aa4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #4332