RI-7944: Handle edge cases when making keys searchable from Browser Page#5638
Draft
RI-7944: Handle edge cases when making keys searchable from Browser Page#5638
Conversation
🛡️ Jit Security Scan Results
✅ No security findings were detected in this PR
Security scan by Jit
|
Contributor
Code Coverage - Frontend unit tests
Test suite run success6408 tests passing in 763 suites. Report generated by 🧪jest coverage report action from 92fe6ea |
dantovska
force-pushed
the
fe/feature/RI-7944/tree-list-index-button
branch
from
d06a440 to
7da66b5
Compare
Base automatically changed from
fe/feature/RI-7944/tree-list-index-button
to
main
March 13, 2026 13:45
Add ScanTypeFilter to RedisFeature enum with version >= 6.0 check. getNamespaceSearchable now proactively skips SCAN with TYPE filter when not supported, avoiding unnecessary errors and log noise. References: #RI-7944 Made-with: Cursor
Show RqeNotAvailable when RediSearch module is missing, matching the guard already present on the main vector search page. References: #RI-7944 Made-with: Cursor
dantovska
force-pushed
the
fe/feature/RI-7944/browser-index-edge-cases
branch
from
abc5ae0 to
92fe6ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Handle two edge cases for the "Make keys searchable from Browser" feature:
SCAN ... TYPEfilter is not supported. Added a proactive version check (RedisFeature.ScanTypeFilter) so the endpoint returns empty results immediately without issuing SCAN commands or producing error logs.useRedisInstanceCompatibilityand shows theRqeNotAvailableguard instead of the create-index form, matching the behavior on the main Vector Search page.Testing
yarn test:api -- --testPathPattern='keys.service.spec.ts'— includes test for Redis < 6 skip.node node_modules/.bin/jest redisinsight/ui/src/pages/vector-search/pages/VectorSearchCreateIndexPage -c jest.config.cjs— includes 4 tests for the module guard.