Skip to content

RI-7969 Vector Search e2e tests#5636

Open
valkirilov wants to merge 1 commit intomainfrom
e2e/RI-7969/vector-search
Open

RI-7969 Vector Search e2e tests#5636
valkirilov wants to merge 1 commit intomainfrom
e2e/RI-7969/vector-search

Conversation

@valkirilov
Copy link
Member

@valkirilov valkirilov commented Mar 13, 2026

What

Add a comprehensive test plan and implementation plan for Vector Search E2E tests.

Note: This PR contains only the planning documents for team review. The actual test implementation will follow in subsequent commits once the plan is approved.

TEST_PLAN.md (Section 8 - Vector Search)

Replaced the previous 4 vague items with 37 flow-based test cases across 9 subsections:

Subsection Cases Scope
8.1 Navigation & RQE Availability 3 Navbar tab navigation, RQE not available, welcome screen
8.2 Create Index - Onboarding 3 Onboarding flow, skip, persistence
8.3 Create Index - Sample Data 3 Start querying, see index definition, seeded queries
8.4 Create Index - Existing Data 7 Schema inference, prefix editing, field CRUD, view toggle, submit
8.5 List Indexes 5 Table display, query/browse/view actions, delete
8.6 Query Page 7 Run, expand/collapse, re-run, delete card, clear all, explain, profile
8.7 Save Query 2 Save modal, cancel
8.8 Query Library 4 View/search, run, load, delete
8.9 Browser Integration 4 View indexed key, create from non-indexed, browse, RQE not available

Build Plan

Implementation across 5 PRs with shared infrastructure:

  1. PR 1 - Infrastructure + navigation tests (page objects, helpers, fixtures, TEST_PLAN.md)
  2. PR 2 - List Indexes tests (5 cases)
  3. PR 3 - Create Index tests (13 cases)
  4. PR 4 - Query + Save + Library tests (13 cases)
  5. PR 5 - Browser Integration tests (4 cases)

Note

Low Risk
Documentation-only updates that expand the E2E test plan; no production or test execution code changes are included in this PR.

Overview
Expands the Vector Search E2E test scope from a short placeholder to a detailed plan. tests/e2e-playwright/TEST_PLAN.md section 8 is rewritten into 9 subsections with 37 flow-based test cases covering navigation/RQE availability, create index (onboarding/sample/existing data), list indexes, query, save query, query library, and browser integration.

Adds a new planning document .cursor/plans/vector_search_e2e_tests_4d61e0e1.plan.md describing the 5-PR implementation breakdown, shared Playwright selector/page-object strategy, and test environment prerequisites.

Written by Cursor Bugbot for commit ca5ab40. This will update automatically on new commits. Configure here.

@valkirilov valkirilov marked this pull request as ready for review March 13, 2026 09:42
@valkirilov valkirilov self-assigned this Mar 13, 2026
@jit-ci
Copy link

jit-ci bot commented Mar 13, 2026

🛡️ Jit Security Scan Results

CRITICAL HIGH MEDIUM

✅ No security findings were detected in this PR


Security scan by Jit

name: Vector Search E2E Tests
overview: Update TEST_PLAN.md with ~37 flow-based Vector Search e2e test cases across 9 subsections, and implement the tests across 5 separate pull requests organized by functional area.
todos:
- id: pr1-infrastructure-and-navigation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just do that as a single PR with 5 commits. It shouldn't take long to review that.

Copy link
Member Author

@valkirilov valkirilov Mar 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think separate PRs work better here, because each one covers a specific area, so when you review it you only need to think about that one thing - like just the create index flow or just the query tests.

Mixing everything into one PR means you have to keep switching context between unrelated parts, which I find makes the review harder. The total effort is the same, but the individual reviews should be quicker.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PS: If the code is not that much, I can combine it in a single PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants