Open
Conversation
References: RI-7969
🛡️ Jit Security Scan Results✅ No security findings were detected in this PR
Security scan by Jit
|
DimoHG
reviewed
Mar 13, 2026
| name: Vector Search E2E Tests | ||
| overview: Update TEST_PLAN.md with ~37 flow-based Vector Search e2e test cases across 9 subsections, and implement the tests across 5 separate pull requests organized by functional area. | ||
| todos: | ||
| - id: pr1-infrastructure-and-navigation |
Contributor
There was a problem hiding this comment.
I'd just do that as a single PR with 5 commits. It shouldn't take long to review that.
Member
Author
There was a problem hiding this comment.
I think separate PRs work better here, because each one covers a specific area, so when you review it you only need to think about that one thing - like just the create index flow or just the query tests.
Mixing everything into one PR means you have to keep switching context between unrelated parts, which I find makes the review harder. The total effort is the same, but the individual reviews should be quicker.
Member
Author
There was a problem hiding this comment.
PS: If the code is not that much, I can combine it in a single PR 👍
DimoHG
approved these changes
Mar 13, 2026
KrumTy
approved these changes
Mar 13, 2026
dantovska
approved these changes
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a comprehensive test plan and implementation plan for Vector Search E2E tests.
Note: This PR contains only the planning documents for team review. The actual test implementation will follow in subsequent commits once the plan is approved.
TEST_PLAN.md (Section 8 - Vector Search)
Replaced the previous 4 vague items with 37 flow-based test cases across 9 subsections:
Build Plan
Implementation across 5 PRs with shared infrastructure:
Note
Low Risk
Documentation-only updates that expand the E2E test plan; no production or test execution code changes are included in this PR.
Overview
Expands the Vector Search E2E test scope from a short placeholder to a detailed plan.
tests/e2e-playwright/TEST_PLAN.mdsection 8 is rewritten into 9 subsections with 37 flow-based test cases covering navigation/RQE availability, create index (onboarding/sample/existing data), list indexes, query, save query, query library, and browser integration.Adds a new planning document
.cursor/plans/vector_search_e2e_tests_4d61e0e1.plan.mddescribing the 5-PR implementation breakdown, shared Playwright selector/page-object strategy, and test environment prerequisites.Written by Cursor Bugbot for commit ca5ab40. This will update automatically on new commits. Configure here.