Skip to content

RI-8039 [E2E] 7.3 Settings -> Workbench Settings #5593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pd-redis wants to merge 4 commits into
base: main
Choose a base branch
from
+184 −18
Open

RI-8039 [E2E] 7.3 Settings -> Workbench Settings #5593

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
08bc78f
test(e2e): add workbench settings tests
pd-redis Mar 4, 2026
c0ee55c
fix(e2e): use heading role for settings accordion locators
pd-redis Mar 10, 2026
31acf48
feat(e2e): enhance Workbench Settings tests with pipeline commands fu…
pd-redis Mar 13, 2026
cec6055
feat(e2e): enhance Workbench Settings tests to verify editor cleanup …
pd-redis Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/e2e-playwright/TEST_PLAN.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,8 +673,8 @@ The test plan is organized by feature area. Tests are grouped for parallel execu
### 7.3 Workbench Settings
| Status | Group | Test Case |
|--------|-------|-----------|
| 🔲 | main | Show editor cleanup switch |
| 🔲 | main | Show pipeline commands setting |
| ✅ | main | Show editor cleanup switch |
| ✅ | main | Show pipeline commands setting |
| 🔲 | main | Configure command timeout (N/A - per-database setting, not in settings page) |

### 7.4 Redis Cloud Settings
Expand Down
24 changes: 24 additions & 0 deletions tests/e2e-playwright/tests/main/settings/workbench-settings/workbench-settings.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
import { test, expect } from '../../../../fixtures/base';

/**
* Workbench Settings tests (TEST_PLAN.md: 7.3 Workbench Settings)
*
* Tests for the Workbench section on the Settings page.
* Verifies editor cleanup switch and pipeline commands setting are displayed.
*
* Note: "Configure command timeout" is N/A -- it's a per-database setting, not on the Settings page.
*/
test.describe('Workbench Settings', () => {
test.beforeEach(async ({ settingsPage }) => {
await settingsPage.goto();
await settingsPage.expandWorkbench();
});

test('should show editor cleanup switch', async ({ settingsPage }) => {
await expect(settingsPage.editorCleanupSwitch).toBeVisible();
Copy link
Contributor

@pawelangelow pawelangelow Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haven't tested it, but if it's easy, it makes sense to add a test that executes something in the workbench so we can validate the switch logic

});

test('should show pipeline commands setting', async ({ settingsPage }) => {
await expect(settingsPage.pipelineCommandsText).toBeVisible();
Copy link
Contributor

@pawelangelow pawelangelow Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and for that one too (I imagine we can set it to 2, and validate just a single command is visible)

Copy link
Contributor Author

@pd-redis pd-redis Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these should be tested here. The test must verify that you can change and save settings. How they affect the related feature, that should be tested as part of that feautre's tests

});
});
Loading