Skip to content

Conversation

@carlosmunoz
Copy link
Contributor

This is a preview for PDF generation of pantheon content using the asciidoctor-pdf library.

To access a basic PDF render of any document just access its full path in the document using the pdf extension. For example:

GET http://<server>/path/to/document.adoc.pdf?draft=true (note the draft parameter is being used)

Known issues and other comments

  • Images are not being inserted into the documents
  • Stylesheets are out-of-the-box
  • The pdf file is being generated on every request

@carlosmunoz carlosmunoz requested a review from a team January 29, 2021 16:45
@carlosmunoz carlosmunoz added the not ready Not ready to be reviewed or merged label Jan 29, 2021
@codecov-io
Copy link

Codecov Report

Merging #505 (3c964da) into master (0c73c45) will decrease coverage by 1.69%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #505      +/-   ##
============================================
- Coverage     57.60%   55.91%   -1.70%     
  Complexity      509      509              
============================================
  Files           134      135       +1     
  Lines          4298     4428     +130     
  Branches        609      627      +18     
============================================
  Hits           2476     2476              
- Misses         1705     1835     +130     
  Partials        117      117              
Flag Coverage Δ Complexity Δ
java 55.91% <0.00%> (-1.70%) 0.00 <0.00> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
...edhat/pantheon/asciidoctor/AsciidoctorService.java 1.98% <0.00%> (-1.81%) 3.00 <0.00> (ø)
...om/redhat/pantheon/servlet/module/PdfRenderer.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
pantheon-bundle/frontend/src/app/searchBeta.tsx 39.85% <0.00%> (-0.30%) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c73c45...3c964da. Read the comment docs.

Copy link
Contributor

@jmarrero jmarrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this PR is not ready 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

not ready Not ready to be reviewed or merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants