Skip to content

Simplify lookup with O(1) set membership check #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Simplify lookup with O(1) set membership check #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cafd1a4
create playbooks set to use in lookups
denini08 May 17, 2025
35d58e5
change list to set in lookup
denini08 May 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion collections/ansible_collections/theforeman/foreman/tests/conftest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ def find_all_test_playbooks():

ALL_TEST_PLAYBOOKS = list(find_all_test_playbooks())
TEST_PLAYBOOKS = sorted([playbook for playbook in ALL_TEST_PLAYBOOKS if not playbook.startswith('inventory_plugin')])
INVENTORY_PLAYBOOKS = sorted(set(ALL_TEST_PLAYBOOKS) - set(TEST_PLAYBOOKS))
TEST_PLAYBOOKS_SET = set(TEST_PLAYBOOKS)
INVENTORY_PLAYBOOKS = sorted(set(ALL_TEST_PLAYBOOKS) - TEST_PLAYBOOKS_SET)


def pytest_addoption(parser):
Expand Down
2 changes: 1 addition & 1 deletion collections/ansible_collections/theforeman/foreman/tests/test_crud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,7 @@ def test_crud(tmpdir, module, vcrmode):

@pytest.mark.parametrize('module', TEST_PLAYBOOKS)
def test_check_mode(tmpdir, module):
if module in ['subscription_manifest', 'templates_import', 'puppetclasses_import']:
if module in {'subscription_manifest', 'templates_import', 'puppetclasses_import'}:
pytest.skip("This module does not support check_mode.")
run = run_playbook_vcr(tmpdir, module, check_mode=True)
assert run.rc == 0
Expand Down
4 changes: 2 additions & 2 deletions collections/ansible_collections/theforeman/foreman/tests/test_module_state.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import py.path
import pytest

from .conftest import TEST_PLAYBOOKS
from .conftest import TEST_PLAYBOOKS_SET

MODULES_PATH = py.path.local(__file__).realpath() / '..' / '..' / 'plugins' / 'modules'

Expand All @@ -22,7 +22,7 @@ def _module_file_path(module):


def _module_is_tested(module):
return module in TEST_PLAYBOOKS
return module in TEST_PLAYBOOKS_SET


@pytest.mark.parametrize('module', ALL_MODULES)
Expand Down