fix(e2e): update plugin references in test value files #4012
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/test e2e-ocp-helm-nightly |
|
The image is available at: /test e2e-ocp-helm |
| - package: ./dynamic-plugins/dist/backstage-plugin-scaffolder-backend-module-gitlab-dynamic | ||
| disabled: false | ||
| - package: ./dynamic-plugins/dist/immobiliarelabs-backstage-plugin-gitlab | ||
| - package: oci://ghcr.io/redhat-developer/rhdh-plugin-export-overlays/immobiliarelabs-backstage-plugin-gitlab:bs_1.45.3__6.13.0!immobiliarelabs-backstage-plugin-gitlab |
There was a problem hiding this comment.
If there's further test failures it could be the corresponding plugin config also need to be copied over from dynamic-plugins.default.yaml, for example this block might be needed for the immobiliarelabs gitlab frontend plugin to be visible in the tests.
PatAKnight
force-pushed
the
update-test-plugin-references
branch
from
ee917df to
b16fd20
Compare
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
/test e2e-ocp-helm-nightly |
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
🚫 Image Push Skipped. The container image push was skipped because the build was skipped (either due to [skip-build] tag or no relevant changes with existing image) |
|
/test e2e-ocp-helm-nightly |
Signed-off-by: Patrick Knight <[email protected]>
Signed-off-by: Patrick Knight <[email protected]>
Signed-off-by: Patrick Knight <[email protected]>
Signed-off-by: Patrick Knight <[email protected]>
Signed-off-by: Patrick Knight <[email protected]>
Signed-off-by: Patrick Knight <[email protected]>
PatAKnight
force-pushed
the
update-test-plugin-references
branch
from
9a19f7a to
6278317
Compare
Signed-off-by: Patrick Knight <[email protected]>
PatAKnight
force-pushed
the
update-test-plugin-references
branch
from
6278317 to
0b8a9e5
Compare
|
/test e2e-ocp-helm-nightly |
|
|
The image is available at: /test e2e-ocp-helm |
|
@PatAKnight: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Description
Updates the plugin references within the E2E values files to now point to their individual OCI artifacts. Still leaves the currently wrapped plugins as is.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer
I have not updated the dynamic-plugins.default.yaml file as we are still in the process of updating the plugin wrappers in PR #3973. We can easily do this in either this PR or the other. Was mainly focused on trying to get PRs unblocked at the moment.
Also, I used all of the recently released OCI artifacts that target backstage 1.45.