Skip to content

fix(install-dynamic-plugins): extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] #3970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 7 commits into from
Jan 9, 2026
Merged

fix(install-dynamic-plugins): extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] #3970

openshift-merge-bot merged 7 commits into from
Jan 9, 2026

Conversation

@rm3l
Copy link
Member

@rm3l rm3l commented Jan 8, 2026 •
edited
Loading

Description

This PR enhances the install-dynamic-plugins.py script to also extract catalog entities from the catalog index OCI image to a configurable dir when the CATALOG_INDEX_IMAGE environment variable is set.

Subsequent PRs will be created in the Operator, Helm Chart and RHDH Local repos to set the extraction dir to /marketplace, so that the extensions can be automatically discovered by the extensions backend providers.
No subsequent PRs needed with the changes done in redhat-developer/rhdh-plugins#2006 (which will automatically add /opt/app-root/src/dynamic-plugins-root/extensions to the discovery search path of the extensions backend providers), once that is merged and a new catalog index image is available.

This should fix the issue with RHDH 1.9 causing no plugins to be displayed in the Extensions UI.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@openshift-ci
Copy link

openshift-ci bot commented Jan 8, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

The image is available at:

/test e2e-ocp-helm

@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from 3999363 to 341f7e6 Compare January 8, 2026 21:14
@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from 341f7e6 to 7a01fed Compare January 8, 2026 21:18
@rm3l rm3l changed the title fix(install-dynamic-plugins): also extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] fix(install-dynamic-plugins): Extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] Jan 8, 2026
@rm3l rm3l changed the title fix(install-dynamic-plugins): Extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] fix(install-dynamic-plugins): extract catalog entities from index image when CATALOG_INDEX_IMAGE is set [RHIDP-11291] Jan 8, 2026
@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from 7a01fed to c1b6b19 Compare January 8, 2026 21:27
@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from c1b6b19 to dc1776b Compare January 8, 2026 21:30
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2026

The image is available at:

/test e2e-ocp-helm

@rm3l rm3l marked this pull request as ready for review January 8, 2026 22:39
@openshift-ci openshift-ci bot requested review from durandom and pabel-rh January 8, 2026 22:39
@rm3l
Copy link
Member Author

rm3l commented Jan 8, 2026

/cc @Fortune-Ndlovu

@openshift-ci openshift-ci bot requested a review from Fortune-Ndlovu January 8, 2026 22:40
@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from dc1776b to 6de9e6e Compare January 9, 2026 08:17
@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

The image is available at:

/test e2e-ocp-helm

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

The image is available at:

/test e2e-ocp-helm

nickboldt
nickboldt reviewed Jan 9, 2026
View reviewed changes
rm3l added 3 commits January 9, 2026 12:36
@rm3l
docs: Update docs accordingly
3b5bae1
@rm3l
Remove existing catalog entities in dest dir for clean sync with the …
90f8c34 
…content of the index image

This is to take into account the case where the catalog index image is updated and contains completely different catalog entities. Without this, we might still see the previous extensions displayed in the Extensions UI
@rm3l
Also remove the /marketplace/catalog-entities files from the containe…
9f01b6e 
…r image

It is now useless as it only contains a README file
@rm3l
Copy link
Member Author

rm3l commented Jan 9, 2026

/test e2e-ocp-helm

rm3l and others added 2 commits January 9, 2026 14:27
@rm3l @karthikjeeyar
Extract extensions catalog entities to '<dynamic-plugins-root>/extens…
01e7005 
…ions' by default

'marketplace' is being replaced in favor of 'extensions'

[1] redhat-developer/rhdh-plugins#2006

Co-authored-by: Karthik Jeeyar <[email protected]>
@rm3l
Search for the catalog entities folder in the 'extensions' folder fro…
f2b51a6 
…m the catalog index image, with a fallback to 'marketplace' (for backward compatibility)
@rm3l rm3l force-pushed the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch from 2c8807c to f2b51a6 Compare January 9, 2026 13:30
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

The image is available at:

/test e2e-ocp-helm

nickboldt
nickboldt approved these changes Jan 9, 2026
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

didn't run anything or really carefully inspect the .py but conceptually agree

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 9, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Jan 9, 2026
nickboldt
nickboldt reviewed Jan 9, 2026
View reviewed changes
@openshift-merge-bot openshift-merge-bot bot merged commit 9059f2d into redhat-developer:main Jan 9, 2026
21 checks passed
@openshift-ci
Copy link

openshift-ci bot commented Jan 9, 2026

@rm3l: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm f2b51a6 link unknown /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rm3l rm3l deleted the rhidp-11291-update-install-dynamic-plugins.py-script-to-copy-the-catalog-entities-files-extracted-from-the-catalog-index-image-to-a-configured-directory branch January 9, 2026 16:45
@rm3l rm3l mentioned this pull request Jan 10, 2026
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nickboldt nickboldt nickboldt approved these changes

@durandom durandom Awaiting requested review from durandom

@pabel-rh pabel-rh Awaiting requested review from pabel-rh

@Fortune-Ndlovu Fortune-Ndlovu Awaiting requested review from Fortune-Ndlovu

Assignees

@nickboldt nickboldt

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rm3l @nickboldt