Skip to content

chore: remove community plugin wrappers #3960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
josephca wants to merge 5 commits into
base: main
Choose a base branch
from
Open

chore: remove community plugin wrappers #3960

josephca wants to merge 5 commits into from

Conversation

@josephca
Copy link
Member

@josephca josephca commented Jan 5, 2026 •
edited by nickboldt
Loading

Description

remove community plugin wrappers from 1.9

Which issue(s) does this PR fix

@openshift-ci openshift-ci bot requested review from dzemanov and teknaS47 January 5, 2026 21:10
@josephca josephca requested a review from nickboldt January 5, 2026 21:10
@josephca josephca changed the title chore: remove 32 community plugin wrappers chore: remove community plugin wrappers Jan 5, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2026

The image is available at:

/test e2e-ocp-helm

nickboldt
nickboldt reviewed Jan 6, 2026
View reviewed changes
@nickboldt nickboldt changed the title chore: remove community plugin wrappers chore: remove community plugin wrappers [skip-build] [skip-e2e] Jan 6, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

The image is available at:

/test e2e-ocp-helm

@nickboldt
Copy link
Member

nickboldt commented Jan 6, 2026

continued in #3963 (4 more wrappers to remove)

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

The image is available at:

/test e2e-ocp-helm

nickboldt
nickboldt reviewed Jan 6, 2026
View reviewed changes
@nickboldt nickboldt mentioned this pull request Jan 6, 2026
Closed
5 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

The image is available at:

/test e2e-ocp-helm

@josephca josephca force-pushed the removeCommunityPlgWrapper branch from c06717f to 3eba605 Compare January 7, 2026 16:02
@christoph-jerolimov
Copy link
Member

christoph-jerolimov commented Jan 7, 2026

Why do you skip the build and esp e2e tests here?

nickboldt
nickboldt reviewed Jan 7, 2026
View reviewed changes
@nickboldt
Copy link
Member

nickboldt commented Jan 7, 2026

Why do you skip the build and esp e2e tests here?

Why do we need to run tests to confirm removal of wrappers is safe? these are all community plugins so we shouldn't be doing e2e tests on them... right?

@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

The image is available at:

/test e2e-ocp-helm

@gashcrumb
Copy link
Member

gashcrumb commented Jan 7, 2026 •
edited
Loading

Would it be worth waiting until we get further with RHIDP-9420 as from a little peeking around, these changes render some lines from our default plugin configuration (like this quay scaffolder thingie or this 3scale backend thingy ) invalid. If we don't intend to ship them by default we should remove the corresponding items from the dynamic-plugins.default.yaml also, or adjust them to use the right OCI reference if it's intended that we have some out-of-the box config for these.

Anyways, I spun up an instance of the PR container locally since it seemed odd the tests failed (aren't they skipped anyways?), seemed to run okay for me.

@josephca
Copy link
Member Author

josephca commented Jan 7, 2026

Why do you skip the build and esp e2e tests here?

It seems to be a glitch. I've noticed it as well.

@nickboldt nickboldt changed the title chore: remove community plugin wrappers [skip-build] [skip-e2e] chore: remove community plugin wrappers Jan 8, 2026
@nickboldt
Copy link
Member

nickboldt commented Jan 8, 2026

Why do you skip the build and esp e2e tests here?

It seems to be a glitch. I've noticed it as well.

not a glitch; I put it on there to save time

@nickboldt
Copy link
Member

nickboldt commented Jan 8, 2026

dynamic-plugins.default.yaml

this will be regenerated once we have a new index container build that excludes these wrappers

@gashcrumb gashcrumb mentioned this pull request Jan 8, 2026
Open
5 tasks
@dzemanov dzemanov mentioned this pull request Jan 12, 2026
Merged
@nickboldt
Copy link
Member

nickboldt commented Jan 12, 2026

waiting until we get further with RHIDP-9420
Almost done there, so we can merge this tomorrow before FF (or else cherrypick it to release-1.9)

@nickboldt nickboldt force-pushed the removeCommunityPlgWrapper branch from d14ddee to 598c76a Compare January 13, 2026 21:23
rhdh-bot and others added 4 commits January 13, 2026 17:24
@rhdh-bot @nickboldt
remove 32 community plugin wrappers
f6b8878
@josephca @nickboldt
remove 32 community plugin wrappers
3ac68ac
@josephca @nickboldt
remove 32 community plugin wrappers
7cbf160
@nickboldt
remove 4 more wrappers: dynamic-plugins/wrappers/backstage-community-…
0b76660 
…plugin-scaffolder-backend-module-quay-dynamic dynamic-plugins/wrappers/backstage-community-plugin-quay dynamic-plugins/wrappers/backstage-community-plugin-tekton dynamic-plugins/wrappers/backstage-community-plugin-redhat-argocd

Signed-off-by: Nick Boldt <[email protected]>
@nickboldt nickboldt force-pushed the removeCommunityPlgWrapper branch from 598c76a to 0b76660 Compare January 13, 2026 21:28
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 13, 2026

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nickboldt nickboldt enabled auto-merge (squash) January 13, 2026 21:30
@nickboldt nickboldt self-requested a review January 13, 2026 21:30
nickboldt
nickboldt approved these changes Jan 13, 2026
View reviewed changes
Copy link
Member

@nickboldt nickboldt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Jan 13, 2026
@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nickboldt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 13, 2026

@josephca: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm 82e53b7 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davidfestal davidfestal davidfestal left review comments

@nickboldt nickboldt nickboldt approved these changes

@dzemanov dzemanov Awaiting requested review from dzemanov

@teknaS47 teknaS47 Awaiting requested review from teknaS47

+1 more reviewer

@benwilcock benwilcock benwilcock left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@nickboldt nickboldt

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@josephca @nickboldt @christoph-jerolimov @gashcrumb @davidfestal @benwilcock @openshift-merge-robot @rhdh-bot