Skip to content

[release-1.3] chore: add authorize job for pr build image workflow #3372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
Sep 5, 2025
Merged

[release-1.3] chore: add authorize job for pr build image workflow #3372

openshift-merge-bot merged 1 commit into from
Sep 5, 2025

Conversation

@Zaperex
Copy link
Member

@Zaperex Zaperex commented Sep 5, 2025

Description

Adds authorize job to the pr-docker-build.yaml workflow for security purposes

Which issue(s) does this PR fix

  • Fixes #?

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

@Zaperex
chore: add authorize job to pr-build-image workflow
30de4ba 
Signed-off-by: Frank Kong <[email protected]>

Signed-off-by: Frank Kong <[email protected]>

rh-pre-commit.version: 2.3.2
rh-pre-commit.check-secrets: ENABLED
@openshift-ci openshift-ci bot requested review from 04kash and dzemanov September 5, 2025 20:12
@Zaperex
Copy link
Member Author

Zaperex commented Sep 5, 2025

/cherrypick 1.2.x

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: once the present PR merges, I will cherry-pick it on top of 1.2.x in a new PR and assign it to you.

Details

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Zaperex
Copy link
Member Author

Zaperex commented Sep 5, 2025

/cherrypick release-1.1

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: once the present PR merges, I will cherry-pick it on top of release-1.1 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Zaperex
Copy link
Member Author

Zaperex commented Sep 5, 2025

/cherrypick release-1.0

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: once the present PR merges, I will cherry-pick it on top of release-1.0 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 5, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Zaperex
Copy link
Member Author

Zaperex commented Sep 5, 2025

/cherrypick release-0.2

@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: once the present PR merges, I will cherry-pick it on top of release-0.2 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Zaperex
Copy link
Member Author

Zaperex commented Sep 5, 2025

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2025

@Zaperex: you cannot LGTM your own PR.

Details

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

The image is available at:

@Zaperex Zaperex requested a review from a team September 5, 2025 20:42
kim-tsao
kim-tsao approved these changes Sep 5, 2025
View reviewed changes
Copy link
Member

@kim-tsao kim-tsao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Sep 5, 2025
@openshift-ci
Copy link

openshift-ci bot commented Sep 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kim-tsao, Zaperex

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Sep 5, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 3ca1ee2 into redhat-developer:release-1.3 Sep 5, 2025
7 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: new pull request created: #3373

Details

In response to this:

/cherrypick 1.2.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2025
Merged
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: new pull request created: #3374

Details

In response to this:

/cherrypick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2025
Merged
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: new pull request created: #3375

Details

In response to this:

/cherrypick release-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2025
Merged
@openshift-cherrypick-robot
Copy link
Contributor

openshift-cherrypick-robot commented Sep 5, 2025

@Zaperex: new pull request created: #3376

Details

In response to this:

/cherrypick release-0.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Sep 5, 2025
Merged
@Zaperex Zaperex deleted the add-authorize-job-to-release-1.3 branch September 5, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kim-tsao kim-tsao kim-tsao approved these changes

@04kash 04kash Awaiting requested review from 04kash

@dzemanov dzemanov Awaiting requested review from dzemanov

Assignees

@kim-tsao kim-tsao

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Zaperex @openshift-cherrypick-robot @kim-tsao