Skip to content

[release-1.6] test(topology): introduce e2e tests for Topology with RBAC #2761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.6
Choose a base branch
from

Conversation

dzemanov
Copy link
Member

Description

This is a manual cherry pick for e2e tests for newly added Topology permissions with RBAC.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Copy link
Contributor

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicating my review so that we don't forget to make changes to the release-1.6 PR as well.

@dzemanov dzemanov force-pushed the e2e-topology-permissions-release-1.6 branch from dd05ec1 to 18ddae4 Compare April 15, 2025 09:32
Copy link
Contributor

@christoph-jerolimov
Copy link
Member

/retest

Signed-off-by: Dominika Zemanovicova <[email protected]>
@dzemanov dzemanov force-pushed the e2e-topology-permissions-release-1.6 branch from 18ddae4 to fa333ae Compare April 17, 2025 07:34
Copy link
Contributor

@dzemanov
Copy link
Member Author

/retest

1 similar comment
@dzemanov
Copy link
Member Author

/retest

Copy link
Member

@PatAKnight PatAKnight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@PatAKnight
Copy link
Member

/retest

1 similar comment
@AndrienkoAleksandr
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndrienkoAleksandr, PatAKnight

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PatAKnight
Copy link
Member

/retest

4 similar comments
@PatAKnight
Copy link
Member

/retest

@dzemanov
Copy link
Member Author

/retest

@dzemanov
Copy link
Member Author

/retest

@dzemanov
Copy link
Member Author

/retest

@PatAKnight
Copy link
Member

/hold

@AndrienkoAleksandr
Copy link
Contributor

/retest

Copy link

openshift-ci bot commented Apr 29, 2025

@dzemanov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests fa333ae link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@dzemanov
Copy link
Member Author

@AndrienkoAleksandr this one needs to go after #2757 as it assumes the roles that #2757 introduces are already present

Copy link
Contributor

github-actions bot commented May 7, 2025

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants