-
Notifications
You must be signed in to change notification settings - Fork 179
[release-1.6] test(topology): introduce e2e tests for Topology with RBAC #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release-1.6
Are you sure you want to change the base?
[release-1.6] test(topology): introduce e2e tests for Topology with RBAC #2761
Conversation
The image is available at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Duplicating my review so that we don't forget to make changes to the release-1.6 PR as well.
dd05ec1
to
18ddae4
Compare
The image is available at: |
/retest |
Signed-off-by: Dominika Zemanovicova <[email protected]>
18ddae4
to
fa333ae
Compare
The image is available at: |
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
1 similar comment
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndrienkoAleksandr, PatAKnight The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
4 similar comments
/retest |
/retest |
/retest |
/retest |
/hold |
/retest |
@dzemanov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@AndrienkoAleksandr this one needs to go after #2757 as it assumes the roles that #2757 introduces are already present |
This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 21 days. |
Description
This is a manual cherry pick for e2e tests for newly added Topology permissions with RBAC.
Which issue(s) does this PR fix
PR acceptance criteria
Please make sure that the following steps are complete:
How to test changes / Special notes to the reviewer