Skip to content

[release-1.6] chore(e2e): introduce e2e tests for RBAC Auditor log #2760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: release-1.6
Choose a base branch
from

Conversation

dzemanov
Copy link
Member

Description

This is a manual cherry pick for the new tests of Auditor service in RBAC plugin.

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Dominika Zemanovicova <[email protected]>
@openshift-ci openshift-ci bot requested review from josephca and psrna April 14, 2025 08:53
@dzemanov dzemanov changed the title chore(e2e): introduce e2e tests for RBAC Auditor log [release-1.6] chore(e2e): introduce e2e tests for RBAC Auditor log Apr 14, 2025
Copy link
Contributor

Copy link
Member

@ciiay ciiay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Verified the build on a cluster that the RBAC plugin works as expected.

Copy link

openshift-ci bot commented Apr 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ciiay
Once this PR has been reviewed and has the lgtm label, please assign subhashkhileri for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@christoph-jerolimov
Copy link
Member

/retest

@ciiay
Copy link
Member

ciiay commented Apr 15, 2025

/test e2e-tests

7 similar comments
@ciiay
Copy link
Member

ciiay commented Apr 15, 2025

/test e2e-tests

@ciiay
Copy link
Member

ciiay commented Apr 15, 2025

/test e2e-tests

@ciiay
Copy link
Member

ciiay commented Apr 16, 2025

/test e2e-tests

@ciiay
Copy link
Member

ciiay commented Apr 16, 2025

/test e2e-tests

@AndrienkoAleksandr
Copy link
Contributor

/test e2e-tests

@ciiay
Copy link
Member

ciiay commented Apr 17, 2025

/test e2e-tests

@ciiay
Copy link
Member

ciiay commented Apr 23, 2025

/test e2e-tests

Copy link

openshift-ci bot commented Apr 23, 2025

@dzemanov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-tests 2817ebb link true /test e2e-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@PatAKnight
Copy link
Member

/hold

@AndrienkoAleksandr
Copy link
Contributor

/retest

@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants