Skip to content

docs(#4486): add entity kind names to boost AGENTS.md naming section - #4530

Merged
gabemontero merged 1 commit into
mainfrom
agent/4486-entity-kind-naming
Sep 2, 2026
Merged

docs(#4486): add entity kind names to boost AGENTS.md naming section#4530
gabemontero merged 1 commit into
mainfrom
agent/4486-entity-kind-naming

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Add canonical entity kind names with exact casing to the Naming subsection in the boost workspace AGENTS.md. The names are sourced from boost-common/src/aiAssetTaxonomy.ts (the single source of truth for the AI asset taxonomy): AiResource, AiModelServerAPI, API, and Resource, each with their associated spec.type values.

This gives both code and review agents an immediate reference for correct entity kind casing (e.g., AiResource not AIResource) without requiring them to read the taxonomy source file.


Closes #4486

Post-script verification

  • Branch is not main/master (agent/4486-entity-kind-naming)
  • Secret scan passed (gitleaks — c3d945b20c14a745ed6007364c4fb9ff13758951..HEAD)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Add canonical entity kind names with exact casing to the Naming
subsection in the boost workspace AGENTS.md. The names are sourced
from boost-common/src/aiAssetTaxonomy.ts (the single source of
truth for the AI asset taxonomy): AiResource, AiModelServerAPI,
API, and Resource, each with their associated spec.type values.

This gives both code and review agents an immediate reference for
correct entity kind casing (e.g., AiResource not AIResource)
without requiring them to read the taxonomy source file.

Closes #4486
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Agent PR ready for human review label Sep 2, 2026
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner September 2, 2026 07:29
@sonarqubecloud

sonarqubecloud Bot commented Sep 2, 2026

Copy link
Copy Markdown

@fullsend-ai-review

fullsend-ai-review Bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 7:30 AM UTC · Completed 7:35 AM UTC

Commit: 5157311 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Cost: $0.96

@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.05%. Comparing base (c3d945b) to head (5157311).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4530   +/-   ##
=======================================
  Coverage   62.05%   62.05%           
=======================================
  Files        2603     2603           
  Lines      104463   104463           
  Branches    29341    29341           
=======================================
  Hits        64822    64822           
  Misses      37784    37784           
  Partials     1857     1857           
Flag Coverage Δ *Carryforward flag
adoption-insights 84.30% <ø> (ø) Carriedforward from c3d945b
ai-integrations 76.15% <ø> (ø) Carriedforward from c3d945b
app-defaults 56.22% <ø> (ø) Carriedforward from c3d945b
augment 46.67% <ø> (ø) Carriedforward from c3d945b
boost 80.51% <ø> (ø)
bulk-import 72.79% <ø> (ø) Carriedforward from c3d945b
cost-management 13.55% <ø> (ø) Carriedforward from c3d945b
dcm 72.09% <ø> (ø) Carriedforward from c3d945b
e2e-adoption-insights 60.00% <ø> (ø) Carriedforward from c3d945b
e2e-extensions 62.32% <ø> (ø) Carriedforward from c3d945b
e2e-global-header 50.35% <ø> (ø) Carriedforward from c3d945b
e2e-homepage 61.11% <ø> (ø) Carriedforward from c3d945b
e2e-intelligent-assistant 47.04% <ø> (ø) Carriedforward from c3d945b
e2e-orchestrator 49.52% <ø> (ø) Carriedforward from c3d945b
e2e-orchestrator-plugin 49.51% <ø> (ø) Carriedforward from c3d945b
e2e-quickstart 55.21% <ø> (ø) Carriedforward from c3d945b
e2e-scorecard 50.21% <ø> (ø) Carriedforward from c3d945b
e2e-theme 16.36% <ø> (ø) Carriedforward from c3d945b
extensions 56.66% <ø> (ø) Carriedforward from c3d945b
global-floating-action-button 71.18% <ø> (ø) Carriedforward from c3d945b
global-header 68.09% <ø> (ø) Carriedforward from c3d945b
homepage 48.48% <ø> (ø) Carriedforward from c3d945b
install-dynamic-plugins 58.57% <ø> (ø) Carriedforward from c3d945b
intelligent-assistant 76.40% <ø> (ø) Carriedforward from c3d945b
konflux 91.98% <ø> (ø) Carriedforward from c3d945b
lightspeed 69.02% <ø> (ø) Carriedforward from c3d945b
mcp-integrations 84.14% <ø> (ø) Carriedforward from c3d945b
orchestrator 71.13% <ø> (ø) Carriedforward from c3d945b
quickstart 63.74% <ø> (ø) Carriedforward from c3d945b
sandbox 79.56% <ø> (ø) Carriedforward from c3d945b
scorecard 87.65% <ø> (ø) Carriedforward from c3d945b
theme 87.91% <ø> (ø) Carriedforward from c3d945b
translations 5.12% <ø> (ø) Carriedforward from c3d945b
x2a 77.10% <ø> (ø) Carriedforward from c3d945b

*This pull request uses carry forward flags. Click here to find out more.


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3d945b...5157311. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@fullsend-ai-review

Copy link
Copy Markdown

Review — approve

Scope: Documentation-only change — 5 lines added to the Naming subsection of workspaces/boost/AGENTS.md.

Summary

This PR adds canonical entity kind names with exact casing to the boost workspace AGENTS.md naming conventions section, addressing issue #4486. The issue was raised after a code agent repeatedly used AIResource (capital I) instead of the correct AiResource (lowercase i) on PR #4221, and the review agent failed to catch it across three runs.

Verification

All four entity kind entries were verified against the single source of truth (boost-common/src/aiAssetTaxonomy.ts):

PR entry Taxonomy kind (comment table) Taxonomy spec.type values Match
AiResource — agents, skills, rules AiResource skill, rule, agent
AiModelServerAPI — model servers (spec.type: ai-model-server) AiModelServerAPI ai-model-server
API — MCP servers (spec.type: mcp-server) API mcp-server
Resource — tools (spec.type: ai-tool), vector stores (spec.type: vector-store) Resource ai-tool, vector-store

The casing warning (NOT \AIResource`)` is well-placed — this was the exact error that motivated issue #4486.

Dimension assessment

Dimension Result
Correctness ✅ All names and spec.type values match the taxonomy source of truth
Security ✅ No code changes; documentation only
Intent & coherence ✅ Precisely scoped to issue #4486; additive-only change
Style & conventions ✅ Follows the existing bullet-point style in the naming section
Documentation currency ✅ Accurately reflects current taxonomy
Cross-repo contracts N/A — no code or API surface affected

No findings at or above the reporting threshold.


Labels: Documentation change in the boost workspace adding entity kind naming conventions

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge documentation Improvements or additions to documentation workspaces/boost labels Sep 2, 2026
@gabemontero
gabemontero merged commit d3877c6 into main Sep 2, 2026
78 of 79 checks passed
@fullsend-ai-retro

fullsend-ai-retro Bot commented Sep 2, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 4:58 PM UTC · Completed 5:13 PM UTC

Commit: 5157311 · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $6.48

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #4530 — Add entity kind names to boost AGENTS.md

This was a documentation-only PR (5 lines added to workspaces/boost/AGENTS.md) implementing issue #4486, itself filed by a prior retro run on PR #4221 where the code agent repeatedly used AIResource instead of AiResource.

Timeline

  1. Aug 27 21:57 — Retro agent creates issue Add canonical entity kind names to boost workspace AGENTS.md naming section #4486.
  2. Aug 27 22:03 — Code agent auto-dispatched (run 33120915908). Fails: policy_denied for claude-opus-5 — zero tokens consumed, both iterations failed identically.
  3. 5-day gap — Issue sits idle; no automatic retry or escalation.
  4. Sep 2 07:21 — Human (mareklibra) triggers /fs-code.
  5. Sep 2 07:23 — Code agent dispatched (run 33603196578). The pre-code.sh script falsely matches dependabot PR chore(deps): bump mysql2 from 3.14.1 to 3.24.2 in /workspaces/quickstart #4521 (mysql2 bump) as already implementing the issue, posts a misleading skip comment, and applies the pr-open label. However, the skip does not halt the run (known bug agents#772), so the agent proceeds and successfully creates PR docs(#4486): add entity kind names to boost AGENTS.md naming section #4530. Cost: $0.93.
  6. Sep 2 07:35 — Review agent approves (run 33603795887). Verified all 4 entity kind names against aiAssetTaxonomy.ts, correctly suppressed a minor ordering nit. Cost: $0.96.
  7. Sep 2 08:15 — Human (mareklibra) diagnoses the false positive, explains it in a comment, removes pr-open label, and runs /fs-code --force.
  8. Sep 2 08:17 — Redundant code agent run (run 33607781306). Cost: $0.69 wasted.
  9. Sep 2 16:57 — Human (gabemontero) approves. Merged.

What went well

Evidence for existing issues

  • agents#772 (pre-code.sh skip does not halt the run): Reproduced exactly. The skip comment was posted and pr-open label applied, but the agent continued running. In this case, the non-halt behavior was accidentally beneficial (the PR was created despite the false positive), but the misleading skip message caused the human to spend ~50 minutes diagnosing the false positive and dispatching a redundant /fs-code --force run ($0.69 wasted + human time).

Proposals filed

  1. Pre-code.sh existing-PR check still falsely matches dependabot PRs with cross-repo issue numbers — despite four closed issues addressing related variants (agents#847, fullsend#5974, fullsend#5900, fullsend#6295), the pre-code.sh script still matched dependabot PR chore(deps): bump mysql2 from 3.14.1 to 3.24.2 in /workspaces/quickstart #4521 because its auto-generated mysql2 changelog contained #4486 — an upstream issue number that GitHub renders as a cross-repo link.

Proposals skipped (target repo not allowed)

File manually or update create_issues.allow_targets in config.yaml:

  • Pre-code.sh existing-PR check falsely matches cross-repo issue numbers in dependabot changelogs (fullsend-ai/agents)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation ready-for-merge All reviewers approved — ready to merge ready-for-review Agent PR ready for human review workspaces/boost

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add canonical entity kind names to boost workspace AGENTS.md naming section

1 participant